[Bug 307183] Re: poldek leaks fds with packages.ndir.dscr.gz

[Elan Ruusamäe]

now it is very visible in kernel %post install.


** Attachment added: "lvm-fdleaks.log"
   http://launchpadlibrarian.net/48857979/lvm-fdleaks.log

-- 
poldek leaks fds with packages.ndir.dscr.gz
https://bugs.launchpad.net/bugs/307183
You received this bug notification because you are subscribed to PLD
Linux.

Status in poldek: New
Status in PLD Linux Distribution: New

Bug description:
attached obfuscated output of:
$ valgrind --track-fds=yes poldek --up

additionally poldek should close fds before invoking subprocess.
such wrapper could be useful all over the code:

16:34:10 @jbj>     fdno = open(path, flags, mode);
16:34:10 @jbj>     if (fdno < 0) return NULL;
16:34:10 @jbj>     if (fcntl(fdno, F_SETFD, FD_CLOEXEC)) {
16:34:10 @jbj>         (void) close(fdno);
16:34:11 @jbj>         return NULL;
16:34:11 @jbj>     }