[Bug 1104011] Re: %doc leaking to subpackages

[Elan Ruusamäe]

15:20:33  baggins> glen: not a bug ;)
15:20:57  baggins> glen: check buildlogs - /usr/bin/install -c -m 644 html/* /var/tmp/libmtp-1.1.5-root-baggins/usr/share/doc/libmtp-1.1.5/html
15:21:34  baggins> glen: libmtp just installs this dir and rpm packages whole docdir
15:21:50  glen> then rpm5 has changed the logic
15:22:01  glen> as rpm4 did rm -rf before it started to install it's own %doc
15:22:34  glen> imho proper logic would be to exit 1 if %doc dir to be installed already exists, i.e neither of  the rpm4/rpm5 behaviours
15:23:16  glen> perhaps add patch: test -d %{buildroot}%{_docdir} && rmdir %{buildroot}%{_docdir}
15:23:31  glen> then if somebody somewhy does install -d for docdir, build will not fail
15:23:51  glen> but if the dir exists and is not empty. build is aborted to avoid such undefined behaviour
15:30:03  baggins> glen: simple, can you check if this is what you wanted? (rpm at master)
15:33:19  glen> baggins: that DOCDIR is per each subpackage?
15:37:30  baggins> glen: I'll delete those branches, just need to double check them
15:37:56  baggins> + DOCDIR=/var/tmp/libmtp-1.1.5-root-baggins/usr/share/doc/libmtp-devel-1.1.5
15:38:09  baggins> glen: so yes, DOCDIR is per package
15:38:29  baggins> + DOCDIR=/var/tmp/libmtp-1.1.5-root-baggins/usr/share/doc/libmtp-1.1.5
15:42:04  glen> baggins: but what do i test? that libmtp is ok? or just the commit?
15:43:31  glen> hmm, it still puts stuff to base pkg
15:44:00  glen> + rmdir /home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5
15:44:00  glen> rmdir: failed to remove '/home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5': Directory not empty
15:44:06  glen> it did not catch error?
15:44:18  glen> baggins: %doc does not have set -e


Executing(%doc): /bin/sh -e /home/users/glen/tmp/rpm-tmp.24011
+ umask 022
+ cd /home/users/glen/rpm/packages/BUILD.x86_64-linux
+ cd libmtp-1.1.5
+ DOCDIR=/home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5
+ export DOCDIR
+ test -d /home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5
+ rmdir /home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5
rmdir: failed to remove '/home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5': Directory not empty
+ /bin/mkdir -p /home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5
+ /usr/lib/rpm/compress-doc
Compressing documentation in /home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5...

Documentation compressed.
+ cp -pr AUTHORS ChangeLog README TODO /home/users/glen/tmp/libmtp-1.1.5-root-glen/usr/share/doc/libmtp-1.1.5
+ exit 0

-- 
You received this bug notification because you are subscribed to PLD
Linux.
https://bugs.launchpad.net/bugs/1104011

Title:
  %doc leaking to subpackages

Status in PLD Linux Distribution:
  New

Bug description:
  --- Day changed N jaan  03 2013
  01:43  glen> i don't understand. how can this package https://github.com/pld-linux/libmtp/blob/auto/th/libmtp-1.1.5-1/libmtp.spec
  01:43  glen> contain /usr/share/doc/html in base package
  01:43  glen> the docs are in -devel: %doc doc/html/*
  01:43  glen> but built rpm dissagrees
  01:44  glen>  rpm -qpl /www/rpm/public/pld/dists/th/PLD/i686/RPMS/libmtp-1.1.5-1.i686.rpm|grep doc/.*html|wc -l
  01:44  glen> warning: /www/rpm/public/pld/dists/th/PLD/i686/RPMS/libmtp-1.1.5-1.i686.rpm: Header V4 DSA signature: NOKEY, key ID e4f1bc2d
  01:44  glen> 163
  01:46  glen> hmm, the docs are in -devel package as well. rpm bug?

To manage notifications about this bug go to:
https://bugs.launchpad.net/pld-linux/+bug/1104011/+subscriptions