SOURCES: mailgraph.init - do not run mailgraph with root privilege...

jajcus jajcus at pld-linux.org
Sun Aug 7 18:46:46 CEST 2005


Author: jajcus                       Date: Sun Aug  7 16:46:46 2005 GMT
Module: SOURCES                       Tag: HEAD
---- Log message:
- do not run mailgraph with root privileges -- parsing logs as root is a very bad idea

---- Files affected:
SOURCES:
   mailgraph.init (1.6 -> 1.7) 

---- Diffs:

================================================================
Index: SOURCES/mailgraph.init
diff -u SOURCES/mailgraph.init:1.6 SOURCES/mailgraph.init:1.7
--- SOURCES/mailgraph.init:1.6	Sun May 25 01:01:09 2003
+++ SOURCES/mailgraph.init	Sun Aug  7 18:46:41 2005
@@ -19,10 +19,15 @@
 	# Check if the service is already running?
 	if [ ! -f /var/lock/subsys/mailgraph ]; then
 		msg_starting mailgraph
-		daemon /usr/bin/mailgraph.pl -d \
+		daemon --user stats /usr/bin/mailgraph.pl -d \
+			--daemon-rrd=/var/lib/mailgraph \
+			--daemon-pid=/var/lib/mailgraph/mailgraph.pid \
 			$([ -n "$MAILLOG_FILE" ] && echo -l $MAILLOG_FILE ) 2>&1
 		RETVAL=$?
-		[ $RETVAL -eq 0 ] && touch /var/lock/subsys/mailgraph
+		if [ $RETVAL -eq 0 ] ; then
+			touch /var/lock/subsys/mailgraph
+			ln -sf /var/lib/mailgraph/mailgraph.pid /var/run/mailgraph.pid
+		fi
 	else
 		msg_already_running atd
 	fi
@@ -31,7 +36,7 @@
 	if [ -f /var/lock/subsys/mailgraph ]; then
 		msg_stopping "mailgraph"
 		killproc mailgraph
-		rm -f /var/lock/subsys/mailgraph /var/run/mailgraph.pid >/dev/null 2>&1
+		rm -f /var/lock/subsys/mailgraph /var/run/mailgraph.pid /var/lib/mailgraph >/dev/null 2>&1
 	else
 		msg_not_running "mailgraph"
 	fi
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/SOURCES/mailgraph.init?r1=1.6&r2=1.7&f=u




More information about the pld-cvs-commit mailing list