SOURCES: syslog.init - create files before chown (is that secure?)

[glen]

Author: glen                         Date: Tue Nov  1 15:48:09 2005 GMT
Module: SOURCES                       Tag: HEAD
---- Log message:
- create files before chown (is that secure?)

---- Files affected:
SOURCES:
   syslog.init (1.24 -> 1.25) 

---- Diffs:

================================================================
Index: SOURCES/syslog.init
diff -u SOURCES/syslog.init:1.24 SOURCES/syslog.init:1.25
--- SOURCES/syslog.init:1.24	Tue Nov  1 16:10:31 2005
+++ SOURCES/syslog.init	Tue Nov  1 16:48:04 2005
@@ -52,9 +52,11 @@
 fi
 
 chown_syslog_files() {
-	[ -z "$RUNAS" ] || return
+	[ -n "$RUNAS" ] || return
 
-	chown ${RUNAS}: $(/usr/sbin/syslogd-listfiles -f "$CONFIG_FILE" -a)
+	local files=$(/usr/sbin/syslogd-listfiles -f "$CONFIG_FILE" -a)
+	touch $files
+	chown ${RUNAS}: $files
 }
 
 RETVAL=0
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/SOURCES/syslog.init?r1=1.24&r2=1.25&f=u