SPECS: noip.spec - use %service - no globs for suid programs

glen glen at pld-linux.org
Sun Mar 5 16:14:45 CET 2006


Author: glen                         Date: Sun Mar  5 15:14:45 2006 GMT
Module: SPECS                         Tag: HEAD
---- Log message:
- use %service
- no globs for suid programs

---- Files affected:
SPECS:
   noip.spec (1.21 -> 1.22) 

---- Diffs:

================================================================
Index: SPECS/noip.spec
diff -u SPECS/noip.spec:1.21 SPECS/noip.spec:1.22
--- SPECS/noip.spec:1.21	Tue Dec 13 14:58:51 2005
+++ SPECS/noip.spec	Sun Mar  5 16:14:39 2006
@@ -13,6 +13,7 @@
 Patch0:		%{name}-Makefile.patch
 Patch1:		%{name}-config_location.patch
 URL:		http://www.no-ip.com/
+BuildRequires:	rpmbuild(macros) >= 1.268
 Requires(post,preun):	/sbin/chkconfig
 Requires:	rc-scripts
 BuildRoot:	%{tmpdir}/%{name}-%{version}-root-%(id -u -n)
@@ -67,17 +68,11 @@
 
 %post
 /sbin/chkconfig --add noip
-if [ -f /var/lock/subsys/noip ]; then
-        /etc/rc.d/init.d/noip restart >&2
-else
-        echo "Run \"/etc/rc.d/init.d/noip start\" to start noip client daemon."
-fi
+%service noip restart "noip client daemon"
 
 %preun
 if [ "$1" = "0" ]; then
-	if [ -f /var/lock/subsys/noip ]; then
-		/etc/rc.d/init.d/noip stop >&2
-	fi
+	%service noip stop
 	/sbin/chkconfig --del noip
 fi
 
@@ -85,7 +80,7 @@
 %defattr(644,root,root,755)
 %doc README.FIRST
 %attr(754,root,root) /etc/rc.d/init.d/noip
-%attr(4750,root,adm) %{_sbindir}/*
+%attr(4750,root,adm) %{_sbindir}/noip
 %attr(600,root,root) %config(noreplace) %verify(not md5 mtime size) %{_sysconfdir}/%{name}.conf
 
 %define date	%(echo `LC_ALL="C" date +"%a %b %d %Y"`)
@@ -94,6 +89,10 @@
 All persons listed below can be reached at <cvs_login>@pld-linux.org
 
 $Log$
+Revision 1.22  2006/03/05 15:14:39  glen
+- use %service
+- no globs for suid programs
+
 Revision 1.21  2005/12/13 13:58:51  glen
 - adapterized (sorted %verify attrs)
 
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/SPECS/noip.spec?r1=1.21&r2=1.22&f=u



More information about the pld-cvs-commit mailing list