SOURCES: hal-free.patch (NEW) - new

arekm arekm at pld-linux.org
Wed Dec 6 10:34:08 CET 2006


Author: arekm                        Date: Wed Dec  6 09:34:08 2006 GMT
Module: SOURCES                       Tag: HEAD
---- Log message:
- new

---- Files affected:
SOURCES:
   hal-free.patch (NONE -> 1.1)  (NEW)

---- Diffs:

================================================================
Index: SOURCES/hal-free.patch
diff -u /dev/null SOURCES/hal-free.patch:1.1
--- /dev/null	Wed Dec  6 10:34:08 2006
+++ SOURCES/hal-free.patch	Wed Dec  6 10:34:03 2006
@@ -0,0 +1,23 @@
+From: John (J5) Palmieri <johnp at redhat.com>
+Date: Mon, 6 Nov 2006 16:48:55 +0000 (-0500)
+Subject: use g_slist_remove_link instead of g_slist_remove
+X-Git-Url: http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=a56a15b90177734c70a8b03d961a7bcabdea2af8
+
+use g_slist_remove_link instead of g_slist_remove
+
+Data would be freed and then g_slist_remove would be called on the
+link which would leave the link in the list, any subsequent iteration
+over the list would cause us to access freed memory.
+---
+
+--- a/hald/hald_dbus.c
++++ b/hald/hald_dbus.c
+@@ -3976,7 +3976,7 @@ local_server_message_handler (DBusConnec
+ 				g_free (hih->introspection_xml);
+ 				g_free (hih->udi);
+ 				g_free (hih);
+-				helper_interface_handlers = g_slist_remove (helper_interface_handlers, i);
++				helper_interface_handlers = g_slist_remove_link (helper_interface_handlers, i);
+ 			}
+ 		}
+ 
================================================================


More information about the pld-cvs-commit mailing list