SOURCES: virtualbox.init - notes

[glen]

Author: glen                         Date: Sat Sep 22 09:57:05 2007 GMT
Module: SOURCES                       Tag: HEAD
---- Log message:
- notes

---- Files affected:
SOURCES:
   virtualbox.init (1.4 -> 1.5) 

---- Diffs:

================================================================
Index: SOURCES/virtualbox.init
diff -u SOURCES/virtualbox.init:1.4 SOURCES/virtualbox.init:1.5
--- SOURCES/virtualbox.init:1.4	Sat Sep 22 11:55:07 2007
+++ SOURCES/virtualbox.init	Sat Sep 22 11:57:00 2007
@@ -18,9 +18,12 @@
 start() {
 	# Check if the service is already running?
 	if [ ! -f /var/lock/subsys/virtualbox ]; then
+		msg_starting virtualbox
+
 		_modprobe single die vboxdrv
+		# XXX: patch udev/dev instead
 		chown root:vbox /dev/vboxdrv
-		msg_starting virtualbox
+
 		daemon --fork VBoxSVC
 		RETVAL=$?
 		[ $RETVAL -eq 0 ] && touch /var/lock/subsys/virtualbox
@@ -31,9 +34,12 @@
 
 stop() {
 	if [ -f /var/lock/subsys/virtualbox ]; then
-		/sbin/rmmod vboxdrv >/dev/null 2>&1
 		# Stop daemons.
 		msg_stopping virtualbox
+
+		# NOTE: rmmod will wait if device is in use, so automatic rmmod probably not the best idea
+		/sbin/rmmod vboxdrv >/dev/null 2>&1
+
 		killproc VBoxSVC
 		rm -f /var/lock/subsys/virtualbox
 	else
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/virtualbox.init?r1=1.4&r2=1.5&f=u