SPECS: gnump3d.spec - remove user/group only on uninstall, not upgrades - s...

[glen]

Author: glen                         Date: Wed Oct 29 22:13:47 2008 GMT
Module: SPECS                         Tag: HEAD
---- Log message:
- remove user/group only on uninstall, not upgrades
- seems noarch pkg to me
- sed 4.0 (equal) is ok too
- skip duplicate files packaging
- provides for user/group
- ConfigFile perl module not used, a copy is included instead and ConfigFile references some test file only

---- Files affected:
SPECS:
   gnump3d.spec (1.3 -> 1.4) 

---- Diffs:

================================================================
Index: SPECS/gnump3d.spec
diff -u SPECS/gnump3d.spec:1.3 SPECS/gnump3d.spec:1.4
--- SPECS/gnump3d.spec:1.3	Wed Oct 29 23:08:14 2008
+++ SPECS/gnump3d.spec	Wed Oct 29 23:13:41 2008
@@ -1,4 +1,6 @@
 # $Revision$, $Date$
+# TODO
+# - use FHS (/var, /usr) instead of /home/services/gnump3d
 Summary:	GNUMP3d is a streaming server for MP3s, OGG vorbis files, movies and other media formats
 Summary(hu.UTF-8):	GNUMP3d egy stream server MP3, OGG, videó és egyéb média fájlokhoz.
 Summary(pl.UTF-8):	GNUMP3d jest serwerem pozwalającym na strumieniowe transmisje dźwięku i filmów
@@ -10,12 +12,14 @@
 Source0:	http://savannah.gnu.org/download/gnump3d/%{name}-%{version}.tar.bz2
 # Source0-md5:	41786650bbc591484c08014a89478bf9
 URL:		http://www.gnu.org/software/gnump3d/
-BuildRequires:	perl-Config-File
-BuildRequires:	sed > 4.0
+BuildRequires:	sed >= 4.0
 Requires(postun):	/usr/sbin/groupdel
 Requires(postun):	/usr/sbin/userdel
 Requires(pre):	/usr/sbin/groupadd
 Requires(pre):	/usr/sbin/useradd
+Provides:	group(gnump3d)
+Provides:	user(gnump3d)
+BuildArch:	noarch
 BuildRoot:	%{tmpdir}/%{name}-%{version}-root-%(id -u -n)
 
 %description
@@ -27,7 +31,6 @@
 - Portable across different varieties of Unix, the GNU Operating
   System, and Microsoft Windows platforms.
 
-
 %description -l hu.UTF-8
 GNUMP3d egy stream szerver MP3, OGG, videó és egyéb média fájlokhoz. A
 következők jellemzik:
@@ -52,50 +55,46 @@
 %setup -q
 %{__sed} -i "s,\`perl.*\`,%{perl_vendorlib}/," Makefile
 
-%build
-
 %install
 rm -rf $RPM_BUILD_ROOT
-
 %{__make} install \
 	PREFIX=$RPM_BUILD_ROOT \
 	MANDIR=%{_mandir}/man1
-cd $RPM_BUILD_ROOT%{_bindir}
-ln -sf gnump3d{2,}
+
+ln -sf gnump3d2 $RPM_BUILD_ROOT%{_bindir}/gnump3d
 %{__sed} -i "s|^user =.*|user = gnump3d|" $RPM_BUILD_ROOT%{_sysconfdir}/gnump3d/gnump3d.conf
 %{__sed} -i "s@/var/\([^/]*\)/gnump3d@/home/services/gnump3d/\1@" $RPM_BUILD_ROOT%{_sysconfdir}/gnump3d/gnump3d.conf
 install -d $RPM_BUILD_ROOT/home/services/gnump3d/{log,cache}
 touch $RPM_BUILD_ROOT/home/services/gnump3d/cache/serving
 
-
 %clean
 rm -rf $RPM_BUILD_ROOT
 
-
 %pre
 %groupadd -g 202 gnump3d
 %useradd -u 202 -r -d /home/services/gnump3d -s /bin/false -c "GNUMP3d User" -g gnump3d gnump3d
 
 %postun
-%userremove gnump3d
-%groupremove gnump3d
-
+if [ "$1" = "0" ]; then
+	%userremove gnump3d
+	%groupremove gnump3d
+fi
 
 %files
 %defattr(644,root,root,755)
+%dir %{_sysconfdir}/gnump3d
+# XXX %config tags for config files!
+%{_sysconfdir}/gnump3d/*
 %attr(755,root,root) %{_bindir}/*
 %{_datadir}/%{name}
 %{_mandir}/man1/*
-
 %dir %{perl_vendorlib}/gnump3d
 %{perl_vendorlib}/gnump3d/*
 
-%dir %{_sysconfdir}/gnump3d
-%{_sysconfdir}/gnump3d/*
-
 %dir /home/services/gnump3d
+# XXX own dirs by root, let it be group writable, unless there's good reason otherwise
 %attr(755,gnump3d,gnump3d) /home/services/gnump3d/log
-%attr(755,gnump3d,gnump3d) /home/services/gnump3d/cache
+%dir %attr(755,gnump3d,gnump3d) /home/services/gnump3d/cache
 %attr(755,gnump3d,gnump3d) /home/services/gnump3d/cache/serving
 
 %define date	%(echo `LC_ALL="C" date +"%a %b %d %Y"`)
@@ -104,6 +103,14 @@
 All persons listed below can be reached at <cvs_login>@pld-linux.org
 
 $Log$
+Revision 1.4  2008/10/29 22:13:41  glen
+- remove user/group only on uninstall, not upgrades
+- seems noarch pkg to me
+- sed 4.0 (equal) is ok too
+- skip duplicate files packaging
+- provides for user/group
+- ConfigFile perl module not used, a copy is included instead and ConfigFile references some test file only
+
 Revision 1.3  2008/10/29 22:08:14  pawelz
 - pl
 
@@ -114,4 +121,3 @@
 Revision 1.1  2008/10/29 20:04:07  uzsolt
 - initial
 - need testing!
-
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SPECS/gnump3d.spec?r1=1.3&r2=1.4&f=u