packages: kde4qtbrs.sh - no bashism, formatting, brief desc, use secure tmp

glen glen at pld-linux.org
Mon Feb 22 09:29:59 CET 2010


Author: glen                         Date: Mon Feb 22 08:29:59 2010 GMT
Module: packages                      Tag: HEAD
---- Log message:
- no bashism, formatting, brief desc, use secure tmp

---- Files affected:
packages:
   kde4qtbrs.sh (1.1 -> 1.2) 

---- Diffs:

================================================================
Index: packages/kde4qtbrs.sh
diff -u packages/kde4qtbrs.sh:1.1 packages/kde4qtbrs.sh:1.2
--- packages/kde4qtbrs.sh:1.1	Sun Feb 21 19:47:20 2010
+++ packages/kde4qtbrs.sh	Mon Feb 22 09:29:53 2010
@@ -1,18 +1,28 @@
-#!/bin/bash
+#!/bin/sh
 #
-# You need to install all Qt*-devel packages
+# Inspect package source and find Qt related build dependencies.
 #
-# auth: shadzik at pld-linux.org
+# NOTE: You need to install all Qt*-devel packages for the script to report
+# success.
+#
+# Author: shadzik at pld-linux.org
 
-if [ "$1" == "" ]; then
+if [ $# = 0 ]; then
 	echo "Usage: $0 <kdemodule>-<version>"
-	exit 0
+	exit 1
 fi
 
-rm -f /tmp/qtbrs
-HEADERS=$(grep -E -r '^#include\ <Q.*' BUILD/$1 |awk '{print $2}' |sort -u |sed -e 's/<//g;s/>//g')
+t=$(mktemp)
+rm -f $t
+HEADERS=$(grep -E -r '^#include\ <Q.*' BUILD/$1 | awk '{print $2}' | sort -u | sed -e 's/<//g;s/>//g')
 
-for i in $HEADERS; do find /usr/include/qt4 -print |grep $i |xargs rpm -qf >>/tmp/qtbrs; done
+for i in $HEADERS; do
+   	find /usr/include/qt4 -print | grep $i |xargs rpm -qf >> $t
+done
 
-for i in $(cat /tmp/qtbrs |sort -u); do ver=$(echo $i|sed -e 's/[a-zA-Z].*-devel-//g;s/-[0-9].*//g');i=$(echo $i|sed -e "s/-[0-9].*//g");echo -e "BuildRequires:\t$i >= $ver"; done
-rm -f /tmp/qtbrs
+for i in $(cat $t | sort -u); do
+	ver=$(echo $i | sed -e 's/[a-zA-Z].*-devel-//g;s/-[0-9].*//g')
+	i=$(echo $i | sed -e "s/-[0-9].*//g")
+	echo -e "BuildRequires:\t$i >= $ver"
+done
+rm -f $t
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/kde4qtbrs.sh?r1=1.1&r2=1.2&f=u



More information about the pld-cvs-commit mailing list