packages: fetch-crl/fetch-crl.spec, fetch-crl/no-modify-template.patch - us...

[glen]

Author: glen                         Date: Sun Jun 12 19:24:56 2011 GMT
Module: packages                      Tag: HEAD
---- Log message:
- use \001 instead ^A to find autodeps

---- Files affected:
packages/fetch-crl:
   fetch-crl.spec (1.2 -> 1.3) , no-modify-template.patch (1.1 -> 1.2) 

---- Diffs:

================================================================
Index: packages/fetch-crl/fetch-crl.spec
diff -u packages/fetch-crl/fetch-crl.spec:1.2 packages/fetch-crl/fetch-crl.spec:1.3
--- packages/fetch-crl/fetch-crl.spec:1.2	Sat Jun 11 10:36:23 2011
+++ packages/fetch-crl/fetch-crl.spec	Sun Jun 12 21:24:51 2011
@@ -15,22 +15,6 @@
 BuildRequires:	rpm-perlprov >= 4.1-13
 Requires:	openssl
 Obsoletes:	fetch-crl3
-# These requires are only added since file is currently broken so they don't get autogenerated.
-# https://bugzilla.redhat.com/show_bug.cgi?id=699548
-# (file(1) considers file 'data' as it sees ^A inside script)
-Requires:	/usr/bin/perl
-Requires:	perl(File::Basename)
-Requires:	perl(File::Temp)
-Requires:	perl(Getopt::Long)
-Requires:	perl(IO::Select)
-Requires:	perl(IPC::Open3)
-Requires:	perl(LWP)
-Requires:	perl(POSIX)
-Requires:	perl(Sys::Syslog)
-Requires:	perl(Time::Local)
-Requires:	perl(integer)
-Requires:	perl(strict)
-Requires:	perl(vars)
 BuildArch:	noarch
 BuildRoot:	%{tmpdir}/%{name}-%{version}-root-%(id -u -n)
 
@@ -44,8 +28,10 @@
 %setup -q
 %patch0 -p1
 
-# use this to figure out deps
-#sed -i -e 's,
,BLAAA,' %{name}
+# NOTE: this is literal ctrl+a here
+# see https://bugzilla.redhat.com/show_bug.cgi?id=699548
+# (file(1) considers file 'data' as it sees ^A inside script)
+sed -i -e 's,
,\\001,' %{name}
 
 %install
 rm -rf $RPM_BUILD_ROOT
@@ -95,6 +81,9 @@
 All persons listed below can be reached at <cvs_login>@pld-linux.org
 
 $Log$
+Revision 1.3  2011/06/12 19:24:51  glen
+- use \001 instead ^A to find autodeps
+
 Revision 1.2  2011/06/11 08:36:23  glen
 - avoid modifying element in hash
 

================================================================
Index: packages/fetch-crl/no-modify-template.patch
diff -u packages/fetch-crl/no-modify-template.patch:1.1 packages/fetch-crl/no-modify-template.patch:1.2
--- packages/fetch-crl/no-modify-template.patch:1.1	Sat Jun 11 10:36:23 2011
+++ packages/fetch-crl/no-modify-template.patch	Sun Jun 12 21:24:51 2011
@@ -12,6 +12,14 @@
 should had been:
 VERBOSE(3) Writing PEM file /etc/pki/esteid/crl/ESTEID-SK_2007.r0.pem
 
+16:21:09  SamChi> glen: foreach does not copy the value, it assigns each value of the list to the variable
+16:21:31  SamChi> glen: unless it is not a valid lvalue, then it may have to be copied
+16:22:12  SamChi> $ perl -le '@a = qw(a b); foreach (@a) { $_ .= "foobar" }; print "@a"'
+16:22:12  SamChi> afoobar bfoobar
+16:22:55  SamChi> glen: oh, I was wrong about the second part
+16:23:03  SamChi> $ perl -le '@a = qw(a b); foreach my $v (@a, "c") { $v .= "foobar" }; print "@a"'
+16:23:03  SamChi> Modification of a read-only value attempted at -e line 1.
+
 --- fetch-crl-3.0.6/fetch-crl	2011-03-20 05:01:20.000000000 +0200
 +++ fetch-crl-3.0.6/fetch-crl	2011-06-11 11:30:58.731040625 +0300
 @@ -1873,13 +1879,14 @@
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/fetch-crl/fetch-crl.spec?r1=1.2&r2=1.3&f=u
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/fetch-crl/no-modify-template.patch?r1=1.1&r2=1.2&f=u