[packages/rpm-build-tools] When tripping over a GIT_ var, give a useful error
glen
glen at pld-linux.org
Fri Apr 9 10:41:43 CEST 2021
commit 792039e3278035e979dbd47925a56193ead451d1
Author: Paweł Zuzelski <pawelz at execve.pl>
Date: Thu Apr 8 20:50:36 2021 +0000
When tripping over a GIT_ var, give a useful error
Before the script was failing with "package build failed. no more
info". That was very unhelpful. Hopefully this message will make it more
clear what is wrong and in worst case it will be easier to find which
call to Exit_error exactly interrupted the execution.
builder.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/builder.sh b/builder.sh
index d96c9d1..428071e 100755
--- a/builder.sh
+++ b/builder.sh
@@ -1700,7 +1700,7 @@ build_package() {
# may be set by user
unset GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL GIT_TESTING_PORCELAIN_COMMAND_LIST GIT_EDITOR
# fail if something still set
- env | grep ^GIT_ && Exit_error err_build_fail
+ env | grep ^GIT_ && Exit_error err_build_fail "One of GIT_* env variables is still set. The builder script needs to be updated to unset that variable. In the meantime, unset it manually."
local specdir=$(insert_gitlog $SPECFILE)
ulimit -c unlimited
================================================================
---- gitweb:
http://git.pld-linux.org/gitweb.cgi/packages/rpm-build-tools.git/commitdiff/792039e3278035e979dbd47925a56193ead451d1
More information about the pld-cvs-commit
mailing list