[packages/pulseview] upstream patch to fix build with glib2 >= 2.68
atler
atler at pld-linux.org
Mon Aug 16 21:27:09 CEST 2021
commit 8f2f5be0f756305369e691c45ce462df4c68b608
Author: Jan Palus <atler at pld-linux.org>
Date: Mon Aug 16 21:26:44 2021 +0200
upstream patch to fix build with glib2 >= 2.68
glib2.68.patch | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
pulseview.spec | 2 ++
2 files changed, 56 insertions(+)
---
diff --git a/pulseview.spec b/pulseview.spec
index a6d9850..8ad828b 100644
--- a/pulseview.spec
+++ b/pulseview.spec
@@ -13,6 +13,7 @@ Group: X11/Applications/Graphics
Source0: https://sigrok.org/download/source/pulseview/%{name}-%{version}.tar.gz
# Source0-md5: 108a5f095f06a9485d31a0349ea38243
Patch0: %{name}-qt.patch
+Patch1: glib2.68.patch
URL: https://sigrok.org/wiki/PulseView
BuildRequires: Qt5Core-devel >= 5.3
BuildRequires: Qt5Gui-devel >= 5.3
@@ -52,6 +53,7 @@ sigrok.
%prep
%setup -q
%patch0 -p1
+%patch1 -p1
%build
install -d build
diff --git a/glib2.68.patch b/glib2.68.patch
new file mode 100644
index 0000000..f129407
--- /dev/null
+++ b/glib2.68.patch
@@ -0,0 +1,54 @@
+From ed643f0b4ac587204a5243451cda181ee1405d62 Mon Sep 17 00:00:00 2001
+From: =?utf8?q?Stefan=20Br=C3=BCns?= <stefan.bruens at rwth-aachen.de>
+Date: Wed, 28 Apr 2021 02:14:47 +0200
+Subject: [PATCH] Fix broken build due to C++ template behind C linkage
+
+glib/gatomic.h since 2.68 includes type_traits, which causes a compilation
+error:
+In file included from /usr/include/glib-2.0/glib/gatomic.h:31,
+ from /usr/include/glib-2.0/glib/gthread.h:32,
+ from /usr/include/glib-2.0/glib/gasyncqueue.h:32,
+ from /usr/include/glib-2.0/glib.h:32,
+ from /usr/include/libsigrokdecode/libsigrokdecode.h:25,
+ from /home/abuild/rpmbuild/BUILD/pulseview-0.4.2/pv/data/decode/annotation.cpp:21:
+/usr/include/c++/10/type_traits:2308:3: error: template with C linkage
+2308 | template<typename _CTp, typename _Rp>
+
+As libsigrokdecode.h declares extern C linkage itself where necessary,
+remove it from pulseviews include statements from the last two occasions.
+---
+ pv/data/decode/annotation.cpp | 2 --
+ pv/views/trace/decodetrace.cpp | 2 --
+ 2 files changed, 4 deletions(-)
+
+diff --git a/pv/data/decode/annotation.cpp b/pv/data/decode/annotation.cpp
+index 7f233478..f8a5c47b 100644
+--- a/pv/data/decode/annotation.cpp
++++ b/pv/data/decode/annotation.cpp
+@@ -17,9 +17,7 @@
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+-extern "C" {
+ #include <libsigrokdecode/libsigrokdecode.h>
+-}
+
+ #include <cassert>
+ #include <vector>
+diff --git a/pv/views/trace/decodetrace.cpp b/pv/views/trace/decodetrace.cpp
+index 409f1d28..888064d0 100644
+--- a/pv/views/trace/decodetrace.cpp
++++ b/pv/views/trace/decodetrace.cpp
+@@ -17,9 +17,7 @@
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+-extern "C" {
+ #include <libsigrokdecode/libsigrokdecode.h>
+-}
+
+ #include <limits>
+ #include <mutex>
+--
+2.24.0.rc2
+
================================================================
---- gitweb:
http://git.pld-linux.org/gitweb.cgi/packages/pulseview.git/commitdiff/8f2f5be0f756305369e691c45ce462df4c68b608
More information about the pld-cvs-commit
mailing list