[packages/bash] remove missing_closes and format-string patches dropped from spec in 0c16d43
atler
atler at pld-linux.org
Sun Oct 12 14:26:06 CEST 2025
commit 92adb1ded6b3ab0f76067b5ed3b2ee0129c275c2
Author: Jan Palus <atler at pld-linux.org>
Date: Sun Oct 12 14:24:06 2025 +0200
remove missing_closes and format-string patches dropped from spec in 0c16d43
bash-4.2-missing_closes.patch | 39 ---------------------------------------
bash-format-string.patch | 12 ------------
2 files changed, 51 deletions(-)
---
diff --git a/bash-4.2-missing_closes.patch b/bash-4.2-missing_closes.patch
deleted file mode 100644
index 8dfd1d4..0000000
--- a/bash-4.2-missing_closes.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-There are missing calls of close() leading to resource leak (fd leak).
-Simple reproducer:
-. /
-and /proc/$$/fd contain one open fd for each above call
-
-Signed-off-by: Roman Rakus <rrakus at redhat.com>
----
- builtins/evalfile.c | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/builtins/evalfile.c b/builtins/evalfile.c
-index 60f89d1..d30bd96 100644
---- a/builtins/evalfile.c
-+++ b/builtins/evalfile.c
-@@ -133,11 +133,13 @@ file_error_and_exit:
- if (S_ISDIR (finfo.st_mode))
- {
- (*errfunc) (_("%s: is a directory"), filename);
-+ close(fd);
- return ((flags & FEVAL_BUILTIN) ? EXECUTION_FAILURE : -1);
- }
- else if ((flags & FEVAL_REGFILE) && S_ISREG (finfo.st_mode) == 0)
- {
- (*errfunc) (_("%s: not a regular file"), filename);
-+ close(fd);
- return ((flags & FEVAL_BUILTIN) ? EXECUTION_FAILURE : -1);
- }
-
-@@ -146,6 +148,7 @@ file_error_and_exit:
- if (file_size != finfo.st_size || file_size + 1 < file_size)
- {
- (*errfunc) (_("%s: file is too large"), filename);
-+ close(fd);
- return ((flags & FEVAL_BUILTIN) ? EXECUTION_FAILURE : -1);
- }
-
---
-1.7.11.7
-
diff --git a/bash-format-string.patch b/bash-format-string.patch
deleted file mode 100644
index 978033d..0000000
--- a/bash-format-string.patch
+++ /dev/null
@@ -1,12 +0,0 @@
-diff -ur bash-4.2.orig/print_cmd.c bash-4.2/print_cmd.c
---- bash-4.2.orig/print_cmd.c 2012-12-07 15:21:47.381111626 +0000
-+++ bash-4.2/print_cmd.c 2012-12-07 15:22:16.575674624 +0000
-@@ -1394,7 +1394,7 @@
- for (i = 0; amount > 0; amount--)
- indentation_string[i++] = ' ';
- indentation_string[i] = '\0';
-- cprintf (indentation_string);
-+ cprintf ("%s", indentation_string);
- }
-
- static void
================================================================
---- gitweb:
http://git.pld-linux.org/gitweb.cgi/packages/bash.git/commitdiff/92adb1ded6b3ab0f76067b5ed3b2ee0129c275c2
More information about the pld-cvs-commit
mailing list