oidentd-1.9.9.1 patch

[Radoslaw Kojdecki]

On Tue, 2 Oct 2001, Grzegorz 'Dzikus' Sterniczuk wrote:
> On Mon, 1 Oct 2001 20:42:42 +0200 (CEST), you wrote:
> >Can you check this problem on current 2.0.0 oindent ?
> It works, but you can't have any "#" on start of /etc/oident_masq.conf

Heh .. You putted oidentd-2.0.0-1.i386.rpm today, but I downloaded latest
version yesterday :))

Problem I reported was fixed in 2.x, but still exists problem with
comments ("#" on beginning of oident_masq.conf) and with line contains
only white spaces (for example TAB or SPACE that You can't see on first
look). I think this patch should fix this problems.

I have got also another problem.
Look :

[radek at gandalf radek]$ id
uid=500(radek) gid=1000(users) groups=1000(users),16(ttyS),23(audio)
[radek at gandalf radek]$ telnet SOME.HOST 23
[...]
[radek at gandalf radek]$ sudo tail /var/log/messages
Oct  2 02:19:11 gandalf oidentd[16623]: Connection from SOME.HOST (IP.OF.SOME.HOST):0
Oct  2 02:19:11 gandalf oidentd[16623]: [SOME.HOST] Successful lookup: 3514 , 23 : radek (radek)

OK ... it works properly, but :

[radek at gandalf radek]$ id
uid=500(radek) gid=1000(users) groups=1000(users),16(ttyS),23(audio)
[radek at gandalf radek]$ nmap SOME.HOST -p 23

Starting nmap V. 2.53 by fyodor at insecure.org ( www.insecure.org/nmap/ )
Interesting ports on SOME.HOST (IP.OF.SOME.HOST):
Port       State       Service
23/tcp     open        telnet

Nmap run completed -- 1 IP address (1 host up) scanned in 1 second
[radek at gandalf radek]$ sudo tail /var/log/messages
Oct  2 02:22:10 gandalf oidentd[16632]: Connection from SOME.HOST (IP.OF.SOME.HOST):0
Oct  2 02:22:10 gandalf oidentd[16632]: [SOME.HOST] Successful lookup: 3516 , 23 : root (root)


It reports that nmap was runned by root !!! Why root ??

There is not SUID on nmap :)

[radek at gandalf radek]$ ls -l `which nmap`
-rwxr-xr-x    1 root     root       186384 Jul 15  2000 /usr/bin/nmap



regards,

Radek
-- 
---------------------------------------------------------------------
Media-Com Sp. z o.o.                       43-100 Tychy, ul. Długa 19
http://www.media-com.com.pl/           e-mail : info at media-com.com.pl
---------------------------------------------------------------------
-------------- next part --------------
Only in oidentd-2.0.0/src: AA
diff -p -r oidentd-2.0.0.orig/src/oidentd_masq.c oidentd-2.0.0/src/oidentd_masq.c
*** oidentd-2.0.0.orig/src/oidentd_masq.c	Sat Sep 29 21:46:20 2001
--- oidentd-2.0.0/src/oidentd_masq.c	Tue Oct  2 02:05:39 2001
*************** int find_masq_entry(struct sockaddr_stor
*** 124,132 ****
  
  		p = strtok(buf, " \t");
  		if (p == NULL) {
! 			debug("[%s:%d] Missing address parameter", MASQ_MAP, line_num);
! 			goto failure;
  		}
  
  		temp = strchr(p, '/');
  		if (temp != NULL)
--- 124,136 ----
  
  		p = strtok(buf, " \t");
  		if (p == NULL) {
! //			debug("[%s:%d] Missing address parameter", MASQ_MAP, line_num);
! 			continue;
! //			goto failure;
  		}
+ 
+ 		if (*p == '#')
+ 			continue;
  
  		temp = strchr(p, '/');
  		if (temp != NULL)