SOURCES: tdb-tdb_store.patch (NEW), tdb-Makefile-extras.patch (NEW...

[wrobell]

On Sat, Nov 13, 2004 at 11:21:27AM +0100, Tomasz Mateja wrote:
> 
> 
> On Fri, 12 Nov 2004, Artur Frysiak wrote:
> 
> >On Fri, Nov 12, 2004 at 06:52:32PM +0100, Tomasz Mateja wrote:
> >>
> >>
> >>On Fri, 12 Nov 2004, Artur Frysiak wrote:
> >>
> >>>On Fri, Nov 12, 2004 at 09:54:55AM +0000, tommat wrote:
> >>>>Author: tommat                       Date: Fri Nov 12 09:54:55 2004 GMT
> >>>>Module: SOURCES                       Tag: HEAD
> >>>>Index: SOURCES/tdb-Makefile-extras.patch
> >>>>diff -u /dev/null SOURCES/tdb-Makefile-extras.patch:1.1
> >>>>--- /dev/null	Fri Nov 12 09:54:55 2004
> >>>>+++ SOURCES/tdb-Makefile-extras.patch	Fri Nov 12 09:54:50 2004
> >>>>@@ -0,0 +1,11 @@
> >>>>+--- tdb-1.0.6/Makefile.am.orig	2001-12-11 05:05:13.000000000 +0100
> >>>>++++ tdb-1.0.6/Makefile.am	2004-11-12 00:33:16.133127976 +0100
> >>>>+@@ -14,7 +14,7 @@
> >>>>+ endif
> >>>>+
> >>>>+ noinst_PROGRAMS=tdbspeed tdbiterate $(TDBTEST) $(TDBTORTURE)
> >>>>+-bin_PROGRAMS=tdbtool tdbdump
> >>>>++bin_PROGRAMS=tdbtool tdbdump $(noinst_PROGRAMS)
> >>>>+
> >>>>+ lib_LTLIBRARIES=libtdb.la
> >>>>+
> >>>
> >>>This "fix" is incorrect. I you want install some programs then move it to
> >>>bin_PROGRAMS but not add whole noinst_PROGRAMS to bin_PROGRAMS.
> >>>
> >>What's the differece between this fix and fix in which Ill copy paste
> >>whole list ??
> >
> >Shorten Makefile.in, cleaner solution.
> >
> I dont understand, shorten is now. If you have your own better solution - 
> please fix it.
Common... Don't you see that this line is a crap? Moreover it is harder to
spot what programs are installed and maybe there will be programs, which
really should not be installed (i.e. tests) in the future, so your solution
is really error prone.

    wrobell <wrobell at pld-linux.org>