SOURCES: iterm-gcc4.patch (NEW) - fix for gcc-4.x

Witold Filipczyk witekfl at poczta.onet.pl
Thu Oct 19 13:40:39 CEST 2006


On Wed, Oct 18, 2006 at 07:10:09PM +0200, sparky at pld-linux.org wrote:
> On Wed, Oct 18, 2006 at 06:55:12PM +0200, witekfl wrote:
> > Author: witekfl                      Date: Wed Oct 18 16:55:12 2006 GMT
> > Module: SOURCES                       Tag: HEAD
> > ---- Log message:
> > - fix for gcc-4.x
> 
> > +--- iterm-0.5/unix/Xaw/lib/xim.c.old	2006-10-18 18:11:35.000000000 +0200
> > ++++ iterm-0.5/unix/Xaw/lib/xim.c	2006-10-18 18:12:03.000000000 +0200
> > +@@ -63,8 +63,8 @@
> > +         }
> > +       }
> > +     }
> > +-    loop_end:
> > +   }
> > ++loop_end:
> > +   XFree(im_styles);
> 
> I haven't seen the code, but wasn't it ment to work like 'continue',
> instead of 'break' ?
> 
> in such case adding empty instruction ';' should be enough, like that:
> 
>          }
>        }
>      }
> -    loop_end:
> +    loop_end: ;
>    }
>    XFree(im_styles);
> 
> 
> check it !

There are two "for" loops. goto loop_end; breaks the outer loop.
There is no need to check it out. It works.
Nobody uses it anyway.

-- 
Witek


More information about the pld-devel-en mailing list