SOURCES: mysqltuner.patch (NEW) - disable diagnostics module dep - avoid de...

[Przemyslaw Iskra]

On Wed, Nov 26, 2008 at 11:31:06PM +0100, glen wrote:

> + # Set up a few variables for use in the script
> +@@ -230,7 +229,7 @@
> + sub mysql_setup {
> + 	$doremote = 0;
> + 	$remotestring = '';
> +-	my $command = `which mysqladmin`;
> ++	my $command = `[ -x /usr/bin/mysqladmin ] && echo /usr/bin/mysqladmin`;
> + 	chomp($command);
> + 	if (! -e $command) {
> + 		badprint "Unable to find mysqladmin in your \$PATH.  Is MySQL installed?\n";

Everytime someone does something like this Larry Wall kills a kitteh.

Just write it as:

my $command = "/usr/bin/mysqladmin";
unless ( -x $command ) {
	...


-- 
 ____  Sparky{PI] -- Przemyslaw _  ___  _  _  ........... LANG...Pl..Ca..Es..En
/____) ___  ___  _ _ || Iskra  |  | _ \| |  | : WWW........ppcrcd.pld-linux.org
\____\| -_)'___| ||^'||//\\// <   |  _/| |  | : JID......sparky<at>jabberes.org
(____/||   (_-_|_||  ||\\ ||   |_ |_|  |_| _| : Mail....sparky<at>pld-linux.org