SPECS: xorg-driver-video-nvidia.spec - revert baggins breakage, you can't u...

[Elan Ruusamäe]

On Wednesday 18 February 2009 01:38:58 Jan Rekorajski wrote:
> On Tue, 17 Feb 2009, glen wrote:
> > Author: glen                         Date: Tue Feb 17 22:57:21 2009 GMT
> > Module: SPECS                         Tag: HEAD
> > ---- Log message:
> > - revert baggins breakage, you can't use %{release} here or
> > %{release}@%{release}@%{release} recursion and other bad things happen;
> > rel 2
>
> Would you mind explaining how can possibly something that simple as:
>
> %define         rel             1
>
> Release:        %{rel}%{?with_multigl:.mgl}
>
> cause %{release}@%{release}@%{release} recursion and other bad things?
because if you write 'Release: %{rel}@something'  then %{release} becames to 
that after next line in spec (be it another Release: %{release} or some other 
use)

and next use of %{release} in spec... i already said that

the other bad things were broken deps, which also hawk noticed and he reported 
before your changes all was ok (he had pkgs built).

even if you didn't see it right now as there weren't much subpkgs, doesn't 
mean it's good... just don't use %{release} in kernel pkgs as subpks can 
appear anyday.

i short: i've seen it earlier, and i prevented it :) (and no, rpm spec parsing 
hasn't changed meanwhile)

> And think for a moment, with R with that stupid macro you may get a
> VER-X.mgl package and subpackages with R: VER-X. Funny, eh?
yes, that's why you use %{rel} in subpkgs, not %{release}

or, you move that .mgl into %{rel} macro definition, depends how you want the 
propagation.

> Janek

-- 
glen