packages: openldap/ldap.init - properly escape url list

Elan Ruusamäe glen at pld-linux.org
Wed Sep 9 19:22:48 CEST 2009


On Wednesday 09 September 2009 16:45:10 baggins wrote:
> ================================================================
> Index: packages/openldap/ldap.init
> diff -u packages/openldap/ldap.init:1.32 packages/openldap/ldap.init:1.33
> --- packages/openldap/ldap.init:1.32	Thu Sep  3 13:18:01 2009
> +++ packages/openldap/ldap.init	Wed Sep  9 15:45:05 2009
> @@ -52,7 +52,7 @@
>  	if [ -n "$SLAPDNICE" ]; then
>  		SERVICE_RUN_NICE_LEVEL=$SLAPDNICE
>  	fi
> -	daemon /usr/sbin/slapd $ARGS ${SLAPDURLLIST:+ -h "$SLAPDURLLIST"}
> +	daemon /usr/sbin/slapd $ARGS ${SLAPDURLLIST:+ -h \"$SLAPDURLLIST\"}

this is what the fix was about. you assume shell syntax, which is wrong with 
RC_LOGGING=no, likely which is OK for RC_LOGGING=yes

how to make the args compatible for both?

adding eval to start-stop-daemon sounds like asking for more troubles.

conditional on RC_LOGGING In ldap.init script?

and initlog (which takes the shell syntax) should die, yet nobody has done it 
and RC_LOGGING=no has few other incompatabilities (lighttpd reload sometimes 
loses pidfile)

-- 
glen


More information about the pld-devel-en mailing list