packages: gtk2-change-theme/gtk-chtheme.xpm (NEW), gtk2-change-theme/gtk-ch...

[Fryderyk Dziarmagowski]

[ some suggestions regarding desktop file ]

On Sat, 19 Sep 2009 13:26:11 +0200
uzsolt <uzsolt at pld-linux.org> wrote:

> Index: packages/gtk2-change-theme/gtk-chtheme.desktop
> diff -u /dev/null packages/gtk2-change-theme/gtk-chtheme.desktop:1.1
> --- /dev/null	Sat Sep 19 13:26:11 2009
> +++ packages/gtk2-change-theme/gtk-chtheme.desktop	Sat Sep 19 13:26:06 2009
> @@ -0,0 +1,11 @@
> +[Desktop Entry]
> +Version=1.0

Version field is not required (but can be used when .desktop
file is standard conform)

> +Encoding=UTF-8

deprecated, shouldn't be used

> +Name=Gtk-ChTheme
> +GenericName=GTK+ 2.0 theme changer and previewer utility

this is wrong, it should only contain generic name like "Theme changer"

> +Comment=GTK+2.0 Theme Changer

same here, according to spec it should only shortly 
describe functionality of a program (for a tooltip)

> +Exec=/usr/bin/gtk-chtheme

in common location case it shouldn't be a absolute path,
Exec=gtk-chtheme should be used here

> +Terminal=false
> +Type=Application
> +Icon=/usr/share/pixmaps/gtk-chtheme.xpm

same as with Exec, there is no need to put path to icon for common
locations. Icon name should not contain extension for common icon types
(like png, svg and xpm)
[ Icon=gtk-chtheme] 

> +Categories=DesktopSettings;System;

System does not belongs here, GTK; is missing
[ Categories=GTK;DesktopSettings; ]

see for details:
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.0.html
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html

-- 
freetz