packages: tftp-hpa/tftp-hpa.spec, tftp-hpa/tftpd-hpa.inetd - rel 7 - proper...

[Elan Ruusamäe]

(re-posting to list from irc)

On Tuesday 20 July 2010 12:55:23 baggins wrote:
> Author: baggins                      Date: Tue Jul 20 09:55:23 2010 GMT
> Module: packages                      Tag: HEAD
> ---- Log message:
> - rel 7
> - properly force ipv4
...
> packages/tftp-hpa/tftpd-hpa.inetd:1.5 ---
> packages/tftp-hpa/tftpd-hpa.inetd:1.4	Tue Jul 20 11:28:00 2010 +++
> packages/tftp-hpa/tftpd-hpa.inetd	Tue Jul 20 11:55:18 2010
> @@ -2,8 +2,9 @@
>  SOCK_TYPE=dgram
>  PROTOCOL=udp
>  PORT=69
> -FLAGS="wait ipv4"
> +FLAGS=wait
>  USER=root
>  SERVER=tcpd
>  DAEMON=/usr/sbin/tftpd
>  DAEMONARGS="-u tftp -t 30 -s /var/lib/tftp -v"
> +FAMILY=ipv4

this $FAMILY is not supported by any inetd i checked, why you think it's "proper"?
it's either not implemented or support dropped seems to me
(did not try to cvs annotate yet on rc-inetd code).

21:52:39  glen> janekr: err, where is that FAMILY caming from?
21:52:49  glen> janekr: i see no match in xinetd generator
21:54:08  glen> janekr: the result must be in "flags = xxx" xinetd.conf option, which is written only via: $XFLAGS:
21:54:09  glen>     [ "${XFLAGS:-n}" = "n" ]    || echo "   flags       =$XFLAGS"
21:54:24  glen> janekr: 21:54:15 root[load: 0.11]@staff /etc# rpm -qf /etc/sysconfig/rc-inet.script
21:54:24  glen> xinetd-2.3.14-4.x86_64
21:55:49  glen> janekr: and to make it even more desperate, it's nowhere used!
21:55:49  glen> janekr: 21:55:20 root[load: 0.11]@staff /etc# rpm -ql xinetd rc-inetd|xargs grep FAMILY
21:55:49  glen> /etc/rc.d/init.d/rc-inetd:              unset FAMILY INTERFACE CHROOT RPCNAME RPCVERSION
21:55:49  glen> /etc/rc.d/init.d/rc-inetd:      unset FAMILY INTERFACE CHROOT RPCNAME RPCVERSION
21:55:49  glen> /etc/sysconfig/rc-inetd.conf:FAMILY=
21:56:07  glen> janekr: forgot to bump some dep or you just lindly assumed all generators use FAMILY?
21:58:37  glen> janekr: packages/inetd contains also no references to FAMILY, and i know no other inetd to check

-- 
glen