packages: zlib/zlib-lfs.patch (NEW) - new

[Jakub Bogusz]

On Sun, May 23, 2010 at 10:21:26PM +0200, adamg wrote:
> Author: adamg                        Date: Sun May 23 20:21:26 2010 GMT
> Module: packages                      Tag: HEAD
> ---- Log message:
> - new
> 
> ---- Files affected:
> packages/zlib:
>    zlib-lfs.patch (NONE -> 1.1)  (NEW)
> 
> ---- Diffs:
> 
> ================================================================
> Index: packages/zlib/zlib-lfs.patch
> diff -u /dev/null packages/zlib/zlib-lfs.patch:1.1
> --- /dev/null	Sun May 23 22:21:26 2010
> +++ packages/zlib/zlib-lfs.patch	Sun May 23 22:21:21 2010
> @@ -0,0 +1,22 @@
> +Improper condition was introduced in 1.2.5 causing some applications
> +(e.g. cgit) to fail due to conflicting declarations.
> +
> +References:
> +- http://mail.madler.net/pipermail/zlib-devel_madler.net/2010-May/002249.html
> +- http://bugs.debian.org/439980
> +- http://bugs.gentoo.org/show_bug.cgi?id=316377
> +- http://bugs.gentoo.org/show_bug.cgi?id=316855
> +- http://bugs.archlinux.org/task/19280
> +- https://bugs.launchpad.net/ubuntu/+source/libpciaccess/+bug/402178
> +
> +--- zlib-1.2.5/zlib.h~	2010-04-20 06:12:48.000000000 +0200
> ++++ zlib-1.2.5/zlib.h	2010-05-23 22:11:29.241572099 +0200
> +@@ -1578,7 +1578,7 @@
> + #  define gzoffset gzoffset64
> + #  define adler32_combine adler32_combine64
> + #  define crc32_combine crc32_combine64
> +-#  ifdef _LARGEFILE64_SOURCE
> ++#  ifndef _LARGEFILE64_SOURCE
> +      ZEXTERN gzFile ZEXPORT gzopen64 OF((const char *, const char *));
> +      ZEXTERN z_off_t ZEXPORT gzseek64 OF((gzFile, z_off_t, int));
> +      ZEXTERN z_off_t ZEXPORT gztell64 OF((gzFile));

I bet this is wrong: it declares *64 functions as operating on z_off_t
type, which is 32-bit on 32-bit archs.
Actual functions operate on 64-bit z_off64_t.
The patch can lead to problems at runtime (it may be tested e.g. with
gzseek).


-- 
Jakub Bogusz    http://qboosh.pl/