packages: gdk-pixbuf2/gdk-pixbuf2.spec - +x libpixbufloader-*.so, - removed...

[Tomasz Pala]

On Sun, Nov 14, 2010 at 22:50:44 +0100, Jakub Bogusz wrote:

>> -%{__rm} $RPM_BUILD_ROOT%{_libdir}/gdk-pixbuf-2.0/%{abiver}/loaders/*.la
>> +rm -f $RPM_BUILD_ROOT%{_libdir}/gdk-pixbuf-2.0/%{abiver}/loaders/*.la
>> +rm -f $RPM_BUILD_ROOT%{_libdir}/libgdk_pixbuf{,_xlib}-2.0.la
>>  
>> -%{!?with_apidocs:%{__rm} -rf $RPM_BUILD_ROOT%{_gtkdocdir}}
>> +%{!?with_apidocs:rm -rf $RPM_BUILD_ROOT%{_gtkdocdir}}
> 
> %{__rm} is intentional here.
> 
> rm -f doesn't fail if specified file/directory doesn't exist.

Why should it fail? And if we want so - why not plain rm without -f?

>> -%find_lang gdk-pixbuf
>> +%find_lang %{name}
> 
> Wrong, the translation domain is gdk-pixbuf, not gdk-pixbuf2.

Right, I should have changed it to:

%find_lang gdk-pixbuf %{name}

-- 
Tomasz Pala <gotar at pld-linux.org>