packages: libtirpc/libtirpc.spec, libtirpc/libtirpc-nis.patch (NEW), libtir...

[Arkadiusz Miskiewicz]

On Sunday 12 of June 2011, Jakub Bogusz wrote:
> On Sun, Jun 12, 2011 at 03:55:32PM +0200, arekm wrote:
> > Author: arekm                        Date: Sun Jun 12 13:55:32 2011 GMT
> > Module: packages                      Tag: HEAD
> > ---- Log message:
> > - headers in place where it was in glibc
> > 
> > +# FIXME: this allows invalid (unresolved symbols) library to be
> > installed. +# Left until upstream fixes this properly.
> > +%define	no_install_post_check_so	1
> 
> There are more source files, not included in Makefile.am (like
> crypt_client.c, key_call.c, netname.c) - maybe they cover all the missing
> symbols.

... producing more (new) unresolved symbols.

> Distributing broken library is pointless.

Aren't these missing symbols available from glibc? AFAIK glibc people only 
prevented linking with glibc rpc implementation but it is there, providing 
symbols runtime.

> 
> > +# rpc headers for glibc 2.14+
> > +install -d $RPM_BUILD_ROOT%{_includedir}/rpc
> > +ln -s tirpc/netconfig.h $RPM_BUILD_ROOT%{_includedir}/netconfig.h
> > +for i in $RPM_BUILD_ROOT%{_includedir}/tirpc/rpc/*.h; do
> > +	i="$(basename $i)"
> > +	ln -s ../tirpc/rpc/$i $RPM_BUILD_ROOT%{_includedir}/rpc/$i
> > +done
> 
> I don't think this is good idea - additional library is needed anyway.
> So if additional linker option is required (pkg-config --libs libtirpc),
> requiring similar compiler/preprocessor option (pkg-config --cflags
> libtirpc) is rational.

Ok, I'll drop it nex time.

-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/