[packages/git-core] - hardcode completions path to avoid bash+bash-completion BR

[Jakub Bogusz]

On Fri, Jun 14, 2013 at 03:46:17PM +0300, Elan Ruusamäe wrote:
> On 13.06.2013 20:06, qboosh wrote:
> >commit 1db8400f5a741a3f3ae86f1a705d8109783dd946
> >Author: Jakub Bogusz <qboosh at pld-linux.org>
> >Date:   Thu Jun 13 19:06:48 2013 +0200
> >
> >     - hardcode completions path to avoid bash+bash-completion BR
> >
> >  git-core.spec | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >---
> >diff --git a/git-core.spec b/git-core.spec
> >index 4080c8f..1c71b07 100644
> >--- a/git-core.spec
> >+++ b/git-core.spec
> >@@ -30,7 +30,6 @@ Patch3:		cherry-picked-commitlog.patch
> >  URL:		http://git-scm.com/
> >  BuildRequires:	autoconf >= 2.59
> >  BuildRequires:	automake
> >-BuildRequires:	bash-completion >= 2.0
> >  BuildRequires:	curl-devel
> >  BuildRequires:	expat-devel
> >  BuildRequires:	gettext-devel
> >@@ -79,7 +78,7 @@ BuildRoot:	%{tmpdir}/%{name}-%{version}-root-%(id -u -n)
> >  %define		webappdir	%{_sysconfdir}/webapps/%{webapp}
> >  %define		appdir		%{_datadir}/%{webapp}
> >  %define		cgibindir	%{_prefix}/lib/cgi-bin
> >-%define		bash_compdir	%(pkg-config --variable 
> >completionsdir bash-completion || echo /etc/bash_completion.d)
> >+%define		bash_compdir %{_datadir}/bash-completion/completions
> >
> why is hardcoding good?

The path is constant (bash-completion < 2.0 was already not supported by
spec).
The only purpose of bash-completion BR was path resolution and BRing
package which changes behaviour/user experience should be avoided
if possible.


-- 
Jakub Bogusz    http://qboosh.pl/