cmake macros for dirs

Jakub Bogusz qboosh at pld-linux.org
Tue Dec 9 16:01:07 CET 2014


On Tue, Dec 09, 2014 at 09:09:02AM +0100, Arkadiusz Miśkiewicz wrote:
> 
> Some time ago %cmake macro lost -DINCLUDE_INSTALL_DIR
> http://git.pld-linux.org/gitweb.cgi?p=packages/rpm-build-macros.git;a=commitdiff;h=b6ce5bb6a311437b480b901de363d834770f1ab8

INCLUDE_INSTALL_DIR != CMAKE_INCLUDE_INSTALL_DIR
See comment inside for explanation.

> According to:
> /usr/share/cmake/Modules/GNUInstallDirs.cmake
> there are defines for almost every dir example
> 
> CMAKE_INSTALL_INCLUDEDIR and so on.
> 
> Any ideas why we don't set these in %cmake? That would make
> us closer to what %configure gets passed.

AFAIR there was no GNUInstallDirs.cmake at the time of adjusting %cmake
macro.

For standardized variable names it's OK to have them defined.
The only problem for cmake is that most of these macros have relative
default values which causes some developers to (mis)think they're always
relative - thus probably some packages would require fixing.


-- 
Jakub Bogusz    http://qboosh.pl/


More information about the pld-devel-en mailing list