[projects/template-specs] - module in egg info

Arkadiusz Miśkiewicz arekm at maven.pl
Wed Sep 24 17:55:41 CEST 2014


On Wednesday 24 of September 2014, Elan Ruusamäe wrote:
> On 24.09.2014 16:08, arekm wrote:
> > commit ff6e15ce74bf6c9b8264ed090cadae7292becf87
> > Author: Arkadiusz Miśkiewicz <arekm at maven.pl>
> > Date:   Wed Sep 24 15:08:09 2014 +0200
> > 
> >      - module in egg info
> >   
> >   python.spec | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > ---
> > diff --git a/python.spec b/python.spec
> > index 4b374d0..dee1588 100644
> > --- a/python.spec
> > +++ b/python.spec
> > @@ -139,7 +139,7 @@ rm -rf $RPM_BUILD_ROOT
> > 
> >   %{py_sitedir}/*.py[co]
> >   %attr(755,root,root) %{py_sitedir}/*.so
> >   %if "%{py_ver}" > "2.4"
> > 
> > -%{py_sitedir}/TEMPLATE-*.egg-info
> > +%{py_sitedir}/%{module}-%{version}-py*.egg-info
> > 
> >   %endif
> 
> egg  filenames do not always (mostly) match python module name (what you
> import)
> python modules are mostly all lowercased
> egg filenames are mostly CamelCaps
> 
> i think this place should not be macorized therefore

1) TEMPLATE matches 0% of cases

2) %{module}-%{version}-py*.egg-info matches more than 0% of cases 

so 2) is better.

-- 
Arkadiusz Miśkiewicz, arekm / maven.pl


More information about the pld-devel-en mailing list