[packages/ka5-ark] - don't require programs for build, those are used only at runtime

[Elan Ruusamäe]

On 16/05/2019 08:22, baggins wrote:
> commit 80789b35d14e465bd1338d2a2e1bb4428fe61911
> Author: Jan Rękorajski <baggins at pld-linux.org>
> Date:   Thu May 16 07:22:03 2019 +0200
>
>      - don't require programs for build, those are used only at runtime
...
> +--- ark-19.04.1/plugins/clirarplugin/CMakeLists.txt~	2019-05-05 12:43:24.000000000 +0200
> ++++ ark-19.04.1/plugins/clirarplugin/CMakeLists.txt	2019-05-16 07:18:19.440090472 +0200
> +@@ -24,17 +24,3 @@
> +
> + set(SUPPORTED_ARK_MIMETYPES "${SUPPORTED_ARK_MIMETYPES}${SUPPORTED_CLIRAR_MIMETYPES}" PARENT_SCOPE)
> + set(INSTALLED_KERFUFFLE_PLUGINS "${INSTALLED_KERFUFFLE_PLUGINS}kerfuffle_clirar;" PARENT_SCOPE)
> +-
> +-find_program(UNRAR unrar)
> +-if(UNRAR)
> +-    message(STATUS "Found unrar executable: ${UNRAR}")
> +-else()
> +-    message(WARNING "Could not find the unrar executable. Ark requires unrar or unar to extract RAR archives.")
> +-endif()


i think you can do this with cmake commandline args:

-DUNRAR=/usr/bin/unrar

your approach may even be breaking if the code uses the $UNRAR variable