From atler at pld-linux.org  Fri Jan  5 19:02:32 2024
From: atler at pld-linux.org (Jan Palus)
Date: Fri, 5 Jan 2024 19:02:32 +0100
Subject: [packages/pam] - add triggers for removed modules
In-Reply-To: <201cb6739a14557a0ec8bf7c3dd171b4fc06afeb_refs_heads_master@pld-linux.org>
References: <9dcddb5207d0442fa8653c621bd3f316b2d8c3db_refs_heads_master@pld-linux.org>
 <201cb6739a14557a0ec8bf7c3dd171b4fc06afeb_refs_heads_master@pld-linux.org>
Message-ID: <3ow22gqe4slnjad4sz62e6pt6bf7mzmuwibwfqq7pbpubl7yjs@lhrez3ugeb5v>

On 23.12.2023 10:53, baggins wrote:
> commit 201cb6739a14557a0ec8bf7c3dd171b4fc06afeb
> Author: Jan R?korajski <baggins at pld-linux.org>
> Date:   Sat Dec 23 09:24:52 2023 +0100
> 
>     - add triggers for removed modules
> 
>  pam.spec | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> ---
> diff --git a/pam.spec b/pam.spec
> index 8daeb42..a333ab9 100644
> --- a/pam.spec
> +++ b/pam.spec
> @@ -413,7 +413,15 @@ if [ "$1" != 1 ]; then
>  fi
>  exit 0
>  
> -%triggerpostun -- %{name} < 1:1.1.5-8
> +%triggerpostun -- %{name} < 1:1.5.3
> +# removed in 1.5.3
> +if grep -qs pam_tally /etc/pam.d/system-auth; then
> +	%{__sed} -i -e '/pam_tally/d' /etc/pam.d/system-auth
> +fi
> +if grep -qs pam_cracklib /etc/pam.d/system-auth; then
> +	%{__sed} -i -e '/pam_cracklib/ s/pam_cracklib/pam_pwquality/; s/$/ use_authtok/' /etc/pam.d/system-auth
                                                                      ^^^^^^^^^^^^^^^^^

What's the reason for "use_authtok" exactly? There is no module left to
prompt for password now and passwd just fails:

# passwd
passwd: Authentication token manipulation error
passwd: password unchanged


From baggins at pld-linux.org  Sat Jan  6 10:23:53 2024
From: baggins at pld-linux.org (Jan =?utf-8?Q?R=C4=99korajski?=)
Date: Sat, 6 Jan 2024 10:23:53 +0100
Subject: [packages/pam] - add triggers for removed modules
In-Reply-To: <3ow22gqe4slnjad4sz62e6pt6bf7mzmuwibwfqq7pbpubl7yjs@lhrez3ugeb5v>
References: <9dcddb5207d0442fa8653c621bd3f316b2d8c3db_refs_heads_master@pld-linux.org>
 <201cb6739a14557a0ec8bf7c3dd171b4fc06afeb_refs_heads_master@pld-linux.org>
 <3ow22gqe4slnjad4sz62e6pt6bf7mzmuwibwfqq7pbpubl7yjs@lhrez3ugeb5v>
Message-ID: <ZZkcKVbnr3MncGWr@starbug.lan>

On Fri, 05 Jan 2024, Jan Palus wrote:

> On 23.12.2023 10:53, baggins wrote:
> > commit 201cb6739a14557a0ec8bf7c3dd171b4fc06afeb
> > Author: Jan R?korajski <baggins at pld-linux.org>
> > Date:   Sat Dec 23 09:24:52 2023 +0100
> > 
> >     - add triggers for removed modules
> > 
> >  pam.spec | 10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> > ---
> > diff --git a/pam.spec b/pam.spec
> > index 8daeb42..a333ab9 100644
> > --- a/pam.spec
> > +++ b/pam.spec
> > @@ -413,7 +413,15 @@ if [ "$1" != 1 ]; then
> >  fi
> >  exit 0
> >  
> > -%triggerpostun -- %{name} < 1:1.1.5-8
> > +%triggerpostun -- %{name} < 1:1.5.3
> > +# removed in 1.5.3
> > +if grep -qs pam_tally /etc/pam.d/system-auth; then
> > +	%{__sed} -i -e '/pam_tally/d' /etc/pam.d/system-auth
> > +fi
> > +if grep -qs pam_cracklib /etc/pam.d/system-auth; then
> > +	%{__sed} -i -e '/pam_cracklib/ s/pam_cracklib/pam_pwquality/; s/$/ use_authtok/' /etc/pam.d/system-auth
>                                                                       ^^^^^^^^^^^^^^^^^
> 
> What's the reason for "use_authtok" exactly? There is no module left to
> prompt for password now and passwd just fails:
> 
> # passwd
> passwd: Authentication token manipulation error
> passwd: password unchanged

I'd swear I've been following the module docs, but it does not indeed
make sense. I'll fix it asap.

-- 
Jan R?korajski                    | PLD/Linux
SysAdm | baggins<at>pld-linux.org | http://www.pld-linux.org/