[packages/rpm-pld-macros] - big cleanup of the main macros - removed macros identical with upstream - added new hotness for bu

[Jan Rękorajski]

On Thu, 06 Feb 2025, Jakub Bogusz wrote:

> On Wed, Feb 05, 2025 at 07:39:12PM +0100, Jakub Bogusz wrote:
> > On Wed, Feb 05, 2025 at 02:04:02AM +0100, baggins wrote:
> > >  
> > > -%configure {./configure \
> > > -	LDFLAGS="${LDFLAGS:-%rpmldflags}" \
> > > -	CFLAGS="${CFLAGS:-%rpmcflags}" \
> > > -	CXXFLAGS="${CXXFLAGS:-%rpmcxxflags}" \
> > > -	FFLAGS="${FFLAGS:-%rpmcflags}" \
> > > -	FCFLAGS="${FCFLAGS:-%rpmcflags}" \
> > > -	CPPFLAGS="${CPPFLAGS:-%rpmcppflags}" \
> > > -	%{?__cc:CC="%{__cc}"} \
> > > -	%{?__cxx:CXX="%{__cxx}"} \
> > > +%configure { \
> > > +  %{set_build_flags}; \
> > > +  ./configure \
> > >  	--host=%{_target_platform} \
> > >  	--build=%{_target_platform} \
> > >  	--prefix=%{_prefix} \
> > 
> > 
> > This change breaks invocation like:
> > 
> > bash %configure
> > 
> > if given configure is too bashish (now shebang change would be
> > required) - e.g. which.spec
> 
> And more cases:
> 
> 2)
> 
> VAR=val %configure
> 
> (now needs to be changed to export before %configure)
> 
> 3)
> 
> ../%configure ...
> 
> (see e.g. apache.spec)
> 
> This has no obvious replacement.
> In some cases maybe configure symlink would work, depending on source
> directory detection (relative to $0 or relative to $0 realpath)

I addressed shell and dir in 2.043 macros with configuredir and
configureshell macros. configure2_13 already had parametrized dir override, btw.

The requirement to export vars is actually good side effect, this was
inconsistent with all other macros and confusing.

-- 
Jan Rękorajski                    | PLD/Linux
SysAdm | baggins<at>pld-linux.org | http://www.pld-linux.org/