wwwoffle

[Arkadiusz Miskiewicz]

GoTaR <gotar w priv0.onet.pl> writes:

> jednak nadal nie jest w stanie dostać się
> na ftp://ftp.pld.org.pl/.
wwwoffle 2.6d + ipv6 patch is broken in two known to me ways:

- ftp support is broken due to bugs in getnameinfo_or_timeout(). This
function is called from SocketRemoteName() and in ftp.c it's called
with NULL values (if(SocketRemoteName(server_ctrl,&host,NULL,NULL)))
which are passed to getnameinfo_or_timeout() and here segfault as null
pointer dereference.

Patch for this:

--- sockets6.c~	Fri Aug 10 23:28:52 2001
+++ sockets6.c	Fri Aug 10 23:33:32 2001
@@ -508,9 +508,9 @@
  static char _host[NI_MAXHOST],_ip[INET6_ADDRSTRLEN],_port[12];
  static char _unknown_host[]="unknown",_unknown_port[]="0";
 
- *host="unknown";
- *ip="unknown";
- *port="0";
+ if (host) *host="unknown";
+ if (ip) *ip="unknown";
+ if (port) *port="0";

- at this moment wwwoffle doesn't support specifing ipv6 addresses in
URLs (unfortunately I don't remember number of RFC which talks about
format). Try for example lynx ftp://[::1]/ and you will get segfault
in IsLocalHost(). It looks like ParseRequest() is
broken. Unfortunately I was too lazy to fix this.

> GoTaR <gotar w priv0.onet.pl>

ps0. cc to wwwoffle author.
ps1. GoTaR: please apply this patch to our cvs.
-- 
 Arkadiusz Miśkiewicz, AM2-6BONE, 1024/3DB19BBD
 IPv6 ready PLD Linux at http://www.pld.org.pl/
My jsme Borg. Odpor je marný, budete asimilováni