packages: glibc/glibc.spec - run localedb-gen only if $SUPPORTED_LOCALES se...

[Jakub Bogusz]

On Mon, Dec 21, 2009 at 04:23:18PM +0100, Pawel Golaszewski wrote:
> On Mon, 21 Dec 2009, glen wrote:
> > Author: glen                         Date: Mon Dec 21 14:51:29 2009 GMT
> > Module: packages                      Tag: HEAD
> > ---- Log message:
> > - run localedb-gen only if $SUPPORTED_LOCALES set (merge from AC-branch)
> > 
> > ---- Files affected:
> > packages/glibc:
> >    glibc.spec (1.854 -> 1.855) 
> [...]
> >  %post -n localedb-src
> > -/usr/bin/localedb-gen || :
> > +SUPPORTED_LOCALES=
> > +[ -f /etc/sysconfig/i18n ] && . /etc/sysconfig/i18n
> > +[ -f /etc/sysconfig/localedb ] && . /etc/sysconfig/localedb
> > +if [ "$SUPPORTED_LOCALES" ]; then
> > +	localedb-gen || :

Should be >/dev/null 2>&1 IMO

> > +fi
> 
> What is that for?
> localedb-gen will gently display:
> SUPPORTED_LOCALES not set
> You can set it in /etc/sysconfig/i18n file
> 
> ...as it should. If you have localedb-src you should set some locales. 
> Otherwise that package has no sense (does it?)

Yes, it does.
For any use locale data are suitable.
And so it isn't mutually exclusive with glibc-localedb-all - there can
be full locale-database for system-wide use and locale sources for some
specific purposes.


-- 
Jakub Bogusz    http://qboosh.pl/