packages: dovecot/dovecot.spec - copy-pasto (restart correct service), spot...

[Jan Rękorajski]

Why are you doing a "reload" on upgrade?  Don't blindly copy-paste,
if sshd does exec voodoo after a HUP it does not mean every daemon does.
This should be a "restart", you want to exec a new binary on update.
Just reloading configs is totally pointless and may even be harmful
if some options change and old daemon won't grok them and die.

On Sun, 31 Oct 2010, pawelz wrote:

> Author: pawelz                       Date: Sun Oct 31 13:16:04 2010 GMT
> Module: packages                      Tag: HEAD
> ---- Log message:
> - copy-pasto (restart correct service), spotted by arekm, thx
> - rel 4
> 
> ---- Files affected:
> packages/dovecot:
>    dovecot.spec (1.170 -> 1.171) 
> 
> ---- Diffs:
> 
> ================================================================
> Index: packages/dovecot/dovecot.spec
> diff -u packages/dovecot/dovecot.spec:1.170 packages/dovecot/dovecot.spec:1.171
> --- packages/dovecot/dovecot.spec:1.170	Sun Oct 31 02:17:46 2010
> +++ packages/dovecot/dovecot.spec	Sun Oct 31 14:15:59 2010
> @@ -12,7 +12,7 @@
>  Summary(pl.UTF-8):	Serwer IMAP i POP3 pisany głównie z myślą o bezpieczeństwie
>  Name:		dovecot
>  Version:	2.0.6
> -Release:	3
> +Release:	4
>  Epoch:		1
>  License:	MIT (libraries), LGPL v2.1 (the rest)
>  Group:		Networking/Daemons
> @@ -208,7 +208,7 @@
>  
>  %post
>  /sbin/chkconfig --add dovecot
> -%service sshd reload "dovecot"
> +%service dovecot reload "dovecot"
>  
>  %preun
>  if [ "$1" = "0" ]; then
> @@ -341,6 +341,10 @@
>  All persons listed below can be reached at <cvs_login>@pld-linux.org
>  
>  $Log$
> +Revision 1.171  2010/10/31 13:15:59  pawelz
> +- copy-pasto (restart correct service), spotted by arekm, thx
> +- rel 4
> +
>  Revision 1.170  2010/10/31 00:17:46  pawelz
>  - use %service macro
>  - dropped TODO (done)
> ================================================================
> 
> ---- CVS-web:
>     http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/dovecot/dovecot.spec?r1=1.170&r2=1.171&f=u
> 
> _______________________________________________
> pld-cvs-commit mailing list
> pld-cvs-commit w lists.pld-linux.org
> http://lists.pld-linux.org/mailman/listinfo/pld-cvs-commit

-- 
Jan Rękorajski            |  ALL SUSPECTS ARE GUILTY. PERIOD!
baggins<at>mimuw.edu.pl   |  OTHERWISE THEY WOULDN'T BE SUSPECTS, WOULD THEY?
BOFH, MANIAC              |                   -- TROOPS by Kevin Rubio