[Bug 307183] Re: poldek leaks fds with packages.ndir.dscr.gz

[Marcin Banasiak]

Fixed in 63f5fb525b04d276129f21a00a48af196b11a562

** Changed in: poldek
       Status: New => Fix Committed

-- 
You received this bug notification because you are subscribed to PLD
Linux.
https://bugs.launchpad.net/bugs/307183

Title:
  poldek leaks fds with packages.ndir.dscr.gz

Status in poldek:
  Fix Committed
Status in PLD Linux Distribution:
  New

Bug description:
  attached obfuscated output of:
  $ valgrind --track-fds=yes poldek --up

  additionally poldek should close fds before invoking subprocess.
  such wrapper could be useful all over the code:

  16:34:10 @jbj>     fdno = open(path, flags, mode);
  16:34:10 @jbj>     if (fdno < 0) return NULL;
  16:34:10 @jbj>     if (fcntl(fdno, F_SETFD, FD_CLOEXEC)) {
  16:34:10 @jbj>         (void) close(fdno);
  16:34:11 @jbj>         return NULL;
  16:34:11 @jbj>     }

To manage notifications about this bug go to:
https://bugs.launchpad.net/poldek/+bug/307183/+subscriptions