SPECS: cvs.spec - -cvspass.patch removed - causes segfault when .c...

[twittner]

Author: twittner                     Date: Fri Jan 13 22:08:36 2006 GMT
Module: SPECS                         Tag: HEAD
---- Log message:
- -cvspass.patch removed - causes segfault when .cvspass is not accessible:
$ strace cvs up
execve("/usr/bin/cvs", ["cvs", "up"], [/* 73 vars */]) = 0
[...]
access("/home/users/inter/.cvspass", F_OK) = 0
chmod("/home/users/inter/.cvspass", 0600) = -1 EPERM (Operation not permitted)
open("/home/users/inter/.cvspass", O_RDONLY) = -1 EACCES (Permission denied)
open("/home/users/inter/.cvspass", O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 EACCES (Permission denied)
--- SIGSEGV (Segmentation fault) @ 0 (0) ---
+++ killed by SIGSEGV +++
$
 instead of printing appropriate message:
cvs log: warning: failed to open /home/users/xxx/.cvspass for reading: Permission denied
cvs log: authorization failed: server cvs.pld-linux.org rejected access to /cvsroot for user xxx
cvs log: used empty password; try "cvs login" with a real password

---- Files affected:
SPECS:
   cvs.spec (1.162 -> 1.163) 

---- Diffs:

================================================================
Index: SPECS/cvs.spec
diff -u SPECS/cvs.spec:1.162 SPECS/cvs.spec:1.163
--- SPECS/cvs.spec:1.162	Fri Dec  2 00:28:53 2005
+++ SPECS/cvs.spec	Fri Jan 13 23:08:30 2006
@@ -15,7 +15,7 @@
 Summary(zh_CN):	˛˘ˇ˘ľÄ°ćąžšÜŔíϾͳCVS
 Name:		cvs
 Version:	1.11.21
-Release:	2
+Release:	3
 License:	GPL
 Group:		Development/Version Control
 # new: ftp://ftp.gnu.org/non-gnu/cvs/source/feature/%{version}/%{name}-%{version}.tar.bz2
@@ -26,14 +26,13 @@
 Patch0:		%{name}-ipv6.patch
 Patch1:		%{name}-zlib.patch
 Patch2:		%{name}-fixed_buffer.patch
-Patch3:		%{name}-cvspass.patch
-Patch4:		%{name}-home_etc.patch
-Patch5:		%{name}-newnline.patch
-Patch6:		%{name}-no_libnsl.patch
-Patch7:		%{name}-info.patch
-Patch8:		%{name}-ssh.patch
-Patch9:		%{name}-posix.patch
-Patch10:	%{name}-CAN_2005_2693.patch
+Patch3:		%{name}-home_etc.patch
+Patch4:		%{name}-newnline.patch
+Patch5:		%{name}-no_libnsl.patch
+Patch6:		%{name}-info.patch
+Patch7:		%{name}-ssh.patch
+Patch8:		%{name}-posix.patch
+Patch9:		%{name}-CAN_2005_2693.patch
 URL:		http://www.non-gnu.org/cvs/
 BuildRequires:	autoconf >= 2.58
 BuildRequires:	automake >= 1:1.7.9
@@ -210,7 +209,6 @@
 %patch7 -p1
 %patch8 -p1
 %patch9 -p1
-%patch10 -p1
 
 %build
 %{__aclocal}
@@ -294,6 +292,24 @@
 All persons listed below can be reached at <cvs_login>@pld-linux.org
 
 $Log$
+Revision 1.163  2006/01/13 22:08:30  twittner
+- -cvspass.patch removed - causes segfault when .cvspass is not accessible:
+
+$ strace cvs up
+execve("/usr/bin/cvs", ["cvs", "up"], [/* 73 vars */]) = 0
+[...]
+access("/home/users/inter/.cvspass", F_OK) = 0
+chmod("/home/users/inter/.cvspass", 0600) = -1 EPERM (Operation not permitted)
+open("/home/users/inter/.cvspass", O_RDONLY) = -1 EACCES (Permission denied)
+open("/home/users/inter/.cvspass", O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 EACCES (Permission denied)
+--- SIGSEGV (Segmentation fault) @ 0 (0) ---
++++ killed by SIGSEGV +++
+$
+ instead of printing appropriate message:
+cvs log: warning: failed to open /home/users/xxx/.cvspass for reading: Permission denied
+cvs log: authorization failed: server cvs.pld-linux.org rejected access to /cvsroot for user xxx
+cvs log: used empty password; try "cvs login" with a real password
+
 Revision 1.162  2005/12/01 23:28:53  hawk
 - removed ACL patch (its no longer maintained + it has memleaks and possible SEGVs)
 - release 2
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/SPECS/cvs.spec?r1=1.162&r2=1.163&f=u