SPECS: builder - $GET_FILES used only in get_files; optimizations ...

glen glen at pld-linux.org
Tue Jan 17 00:30:00 CET 2006


Author: glen                         Date: Mon Jan 16 23:30:00 2006 GMT
Module: SPECS                         Tag: HEAD
---- Log message:
- $GET_FILES used only in get_files; optimizations engaged
- should fix also possible files with spaces issues

---- Files affected:
SPECS:
   builder (1.375 -> 1.376) 

---- Diffs:

================================================================
Index: SPECS/builder
diff -u SPECS/builder:1.375 SPECS/builder:1.376
--- SPECS/builder:1.375	Tue Jan 17 00:26:02 2006
+++ SPECS/builder	Tue Jan 17 00:29:54 2006
@@ -639,7 +639,6 @@
 
 get_files()
 {
-	GET_FILES="$@"
 	update_shell_title "fetching sources"
 
 	if [ -n "$DEBUG" ]; then
@@ -655,12 +654,11 @@
 			NOCVS="yes"
 		fi
 
-		local nf=$(echo "$GET_FILES" | wc -w)
 		local nc=0
 		local get_files_cvs=""
-		for i in $GET_FILES; do
+		for i in "$@"; do
 			nc=$((nc + 1))
-			SHELL_TITLE_PREFIX="get_files[$nc/$nf]"
+			SHELL_TITLE_PREFIX="get_files[$nc/$#]"
 			update_shell_title "$i"
 			local fp=`nourl "$i"`
 			if [ -f "$fp" ] && [ "$SKIP_EXISTING_FILES" = "yes" ]; then
@@ -805,7 +803,7 @@
 		fi
 
 		if [ "$CHMOD" = "yes" ]; then
-			CHMOD_FILES="`nourl $GET_FILES`"
+			CHMOD_FILES="`nourl "$@"`"
 			if [ -n "$CHMOD_FILES" ]; then
 				chmod $CHMOD_MODE $CHMOD_FILES
 			fi
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/SPECS/builder?r1=1.375&r2=1.376&f=u



More information about the pld-cvs-commit mailing list