SOURCES: initng-plugin-lockfile.patch - fixed fd leakage (thx czarny)
glen
glen at pld-linux.org
Tue Mar 28 19:16:56 CEST 2006
Author: glen Date: Tue Mar 28 17:16:56 2006 GMT
Module: SOURCES Tag: HEAD
---- Log message:
- fixed fd leakage (thx czarny)
---- Files affected:
SOURCES:
initng-plugin-lockfile.patch (1.4 -> 1.5)
---- Diffs:
================================================================
Index: SOURCES/initng-plugin-lockfile.patch
diff -u SOURCES/initng-plugin-lockfile.patch:1.4 SOURCES/initng-plugin-lockfile.patch:1.5
--- SOURCES/initng-plugin-lockfile.patch:1.4 Mon Mar 27 18:42:26 2006
+++ SOURCES/initng-plugin-lockfile.patch Tue Mar 28 19:16:50 2006
@@ -10,10 +10,10 @@
+
+liblockfile_la_LDFLAGS = @PLUGIN_LDFLAGS@
+liblockfile_la_LIBADD = @PLUGIN_LIBS@
-diff -u initng-contrib/plugins/lockfile/initng_lockfile.c initng-0.6.0RC1.plugin/plugins/lockfile/initng_lockfile.c
---- initng-contrib/plugins/lockfile/initng_lockfile.c 2006-03-22 22:55:11.000000000 +0200
-+++ initng-0.6.0RC1.plugin/plugins/lockfile/initng_lockfile.c 2006-03-23 00:10:50.000000000 +0200
-@@ -0,0 +1,87 @@
+diff -u initng-0.6.0RC1.plugin/plugins/lockfile/initng_lockfile.c initng-0.6.0/plugins/lockfile/initng_lockfile.c
+--- initng-0.6.0RC1.plugin/plugins/lockfile/initng_lockfile.c 2006-03-23 00:10:50.000000000 +0200
++++ initng-0.6.0/plugins/lockfile/initng_lockfile.c 2006-03-28 20:15:08.000000000 +0300
+@@ -0,0 +1,91 @@
+/* Initng, a next generation sysvinit replacement.
+ * Copyright (C) 2006 Elan Ruusamäe <glen at pld-linux.org>
+ *
@@ -69,8 +69,12 @@
+ D_("lockfile path [%s]\n", lockfile);
+ // service states from initng_is.h
+ if (IS_UP(service)) {
++ int fd;
+ D_("service got up\n");
-+ creat(lockfile, S_IREAD);
++ fd = creat(lockfile, 0640);
++ if (fd != -1) {
++ close(fd);
++ }
+
+ } else if (IS_DOWN(service)) {
+ D_("service went down\n");
================================================================
---- CVS-web:
http://cvs.pld-linux.org/SOURCES/initng-plugin-lockfile.patch?r1=1.4&r2=1.5&f=u
More information about the pld-cvs-commit
mailing list