pld-builder.new: PLD_Builder/rpm_builder.py - no closing of f

arekm arekm at pld-linux.org
Wed Jul 15 17:28:40 CEST 2009


Author: arekm                        Date: Wed Jul 15 15:28:40 2009 GMT
Module: pld-builder.new               Tag: HEAD
---- Log message:
- no closing of f

---- Files affected:
pld-builder.new/PLD_Builder:
   rpm_builder.py (1.100 -> 1.101) 

---- Diffs:

================================================================
Index: pld-builder.new/PLD_Builder/rpm_builder.py
diff -u pld-builder.new/PLD_Builder/rpm_builder.py:1.100 pld-builder.new/PLD_Builder/rpm_builder.py:1.101
--- pld-builder.new/PLD_Builder/rpm_builder.py:1.100	Wed Jul 15 17:27:46 2009
+++ pld-builder.new/PLD_Builder/rpm_builder.py	Wed Jul 15 17:28:35 2009
@@ -60,7 +60,6 @@
             f = urllib2.urlopen(src_url)
             good = True
         except urllib2.HTTPError, error:
-                f.close()
                 return False
         except urllib2.URLError, error:
             # see errno.h
@@ -86,7 +85,6 @@
             # fail in a way where cron job will retry
             msg = "unable to fetch file, http code: %d" % error.code
             b.log_line(msg)
-            f.close()
             raise IOError, msg
         except urllib2.URLError, error:
             # see errno.h
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/pld-builder.new/PLD_Builder/rpm_builder.py?r1=1.100&r2=1.101&f=u



More information about the pld-cvs-commit mailing list