firewall-init: firewall.d/ipv4/filter - Using intrapositioned negation (`--...

baggins baggins at pld-linux.org
Tue Jan 12 15:00:33 CET 2010


Author: baggins                      Date: Tue Jan 12 14:00:33 2010 GMT
Module: firewall-init                 Tag: HEAD
---- Log message:
- Using intrapositioned negation (`--option ! this`) is deprecated
  in favor of extrapositioned (`! --option this`)

---- Files affected:
firewall-init/firewall.d/ipv4:
   filter (1.18 -> 1.19) 

---- Diffs:

================================================================
Index: firewall-init/firewall.d/ipv4/filter
diff -u firewall-init/firewall.d/ipv4/filter:1.18 firewall-init/firewall.d/ipv4/filter:1.19
--- firewall-init/firewall.d/ipv4/filter:1.18	Wed Dec 30 00:35:55 2009
+++ firewall-init/firewall.d/ipv4/filter	Tue Jan 12 15:00:27 2010
@@ -50,7 +50,7 @@
 #	$iptables -A INPUT -p udp -m state --state NEW --dport 177 -j ACCEPT
 #	$iptables -A INPUT -p tcp -m state --state NEW --dport 220 -j ACCEPT
 #	$iptables -A INPUT -p udp -m state --state NEW --dport 513:514 -j ACCEPT
-#	$iptables -A INPUT -i ! $OUTSIDE_IF -p tcp -m state --state NEW --dport 515 -j ACCEPT
+#	$iptables -A INPUT ! -i $OUTSIDE_IF -p tcp -m state --state NEW --dport 515 -j ACCEPT
 #	$iptables -A INPUT -p udp -m state --state NEW --dport 517:518 -j ACCEPT
 #	$iptables -A INPUT -p tcp -m state --state NEW --dport 873 -j ACCEPT
 #	$iptables -A INPUT -p tcp -m state --state NEW --dport 2121 -j ACCEPT
@@ -98,9 +98,9 @@
 	while read prog ver proto port name ; do
 		[ -z "$name" ] && continue
 		if [ "$proto" = "tcp" ] ; then
-			$iptables -A INPUT -i ! $OUTSIDE_IF -p $proto -m state --state NEW --dport $port -j ACCEPT
+			$iptables -A INPUT ! -i $OUTSIDE_IF -p $proto -m state --state NEW --dport $port -j ACCEPT
 		elif [ "$proto" = "udp" ] ; then
-			$iptables -A INPUT -i ! $OUTSIDE_IF -p $proto -m state --state NEW --dport $port -j ACCEPT
+			$iptables -A INPUT ! -i $OUTSIDE_IF -p $proto -m state --state NEW --dport $port -j ACCEPT
 		fi
 	done
 }
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/firewall-init/firewall.d/ipv4/filter?r1=1.18&r2=1.19&f=u



More information about the pld-cvs-commit mailing list