packages: lyricue/lyricue.spec - more review

[glen]

Author: glen                         Date: Fri May 21 16:22:02 2010 GMT
Module: packages                      Tag: HEAD
---- Log message:
- more review

---- Files affected:
packages/lyricue:
   lyricue.spec (1.6 -> 1.7) 

---- Diffs:

================================================================
Index: packages/lyricue/lyricue.spec
diff -u packages/lyricue/lyricue.spec:1.6 packages/lyricue/lyricue.spec:1.7
--- packages/lyricue/lyricue.spec:1.6	Fri May 21 18:18:24 2010
+++ packages/lyricue/lyricue.spec	Fri May 21 18:21:57 2010
@@ -2,6 +2,8 @@
 # TODO:
 # - Split packages for core, client and remote
 # - Add default access.conf file to package
+# - use %find_lang macro for *.mo
+# - ues perlprovs for perl deps
 Summary:	GNU Lyric Display System, client interface
 Name:		lyricue
 Version:	2.0.0
@@ -50,7 +52,7 @@
 
 %install
 rm -rf $RPM_BUILD_ROOT
-%{make} install \
+%{__make} install \
 	DESTDIR=$RPM_BUILD_ROOT
 
 %clean
@@ -58,12 +60,16 @@
 
 %files
 %defattr(644,root,root,755)
+%docdir %{_docdir}/%{name}
+%doc %{_docdir}/%{name}/*
 %dir %{_sysconfdir}/%{name}
+# XXX this glob is evil, use *.conf or sth, may match something irrelevant, like *~ or *.orig
 %config(noreplace) %{_sysconfdir}/%{name}/*
 %attr(755,root,root) %{_bindir}/%{name}
-%attr(755,root,root) %{_bindir}/lyricue_remote
+%attr(755,root,root) %{_bindir}/%{name}_remote
 %attr(755,root,root) %{_bindir}/import_media
 %dir %{_datadir}/%{name}
+# XXX %find_lang
 %lang(en_US) %dir %{_datadir}/locale/en_US
 %lang(en_US) %dir %{_datadir}/locale/en_US/LC_MESSAGES
 %lang(en_US) %{_datadir}/locale/en_US/LC_MESSAGES/lyricue.mo
@@ -84,8 +90,6 @@
 %lang(sv) %{_datadir}/locale/sv/LC_MESSAGES/lyricue.mo
 %{_datadir}/%{name}/*
 %{_desktopdir}/%{name}.desktop
-%dir %{_docdir}/%{name}
-%doc %{_docdir}/%{name}/*
 
 %files server
 %defattr(644,root,root,755)
@@ -98,6 +102,9 @@
 All persons listed below can be reached at <cvs_login>@pld-linux.org
 
 $Log$
+Revision 1.7  2010/05/21 16:21:57  glen
+- more review
+
 Revision 1.6  2010/05/21 16:18:24  glen
 - mysql server is in mysql base package; adapter
 
================================================================

---- CVS-web:
    http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/lyricue/lyricue.spec?r1=1.6&r2=1.7&f=u