[packages/pldnotify/py] move checker to a class
glen
glen at pld-linux.org
Tue Nov 3 23:15:13 CET 2015
commit e41b0156fc1c9e91494903e15eb8203e051f7882
Author: Elan Ruusamäe <glen at delfi.ee>
Date: Wed Nov 4 00:15:09 2015 +0200
move checker to a class
pldnotify.py | 33 ++++++++++++++++++++++-----------
1 file changed, 22 insertions(+), 11 deletions(-)
---
diff --git a/pldnotify.py b/pldnotify.py
index 269260b..e4b843f 100755
--- a/pldnotify.py
+++ b/pldnotify.py
@@ -45,18 +45,28 @@ class RPMSpec:
return self._macros
"""
-Check for update from release-monitoring.org.
-Raise ValueError or version from anitya project.
+Class containing specific remote repositories,
+i.e Anitya (release-monitoring.org), NPM (nodejs), etc ...
+
"""
-def rmo_check(name):
- distro = "pld-linux"
- url = "https://release-monitoring.org/api/project/%s/%s" % (distro, name)
- response = requests.get(url)
- data = response.json()
- if 'error' in data:
- raise ValueError, data['error']
+class Checker:
+ distro = 'pld-linux'
+
+ def __init__(self, name):
+ self.name = name
+
+ """
+ Check for update from release-monitoring.org (Anitya).
+ Raise ValueError or version from anitya project.
+ """
+ def anitya(self):
+ url = "https://release-monitoring.org/api/project/%s/%s" % (self.distro, self.name)
+ response = requests.get(url)
+ data = response.json()
+ if 'error' in data:
+ raise ValueError, data['error']
- return data['version']
+ return data['version']
def check_package(package):
s = RPMSpec(package)
@@ -64,7 +74,8 @@ def check_package(package):
name = macros['name']
version = macros['version']
print "%s: %s" % (name, version)
- ver = rmo_check(name)
+ check = Checker(name)
+ ver = check.anitya()
print "Anitya: %s" % ver
cmp = s.compare(ver)
================================================================
---- gitweb:
http://git.pld-linux.org/gitweb.cgi/packages/pldnotify.git/commitdiff/e41b0156fc1c9e91494903e15eb8203e051f7882
More information about the pld-cvs-commit
mailing list