[packages/pjproject] disable PJ_HASH_USE_OWN_TOLOWER, as Digium recommends

jajcus jajcus at pld-linux.org
Thu Dec 8 13:49:17 CET 2016


commit 3ca848fd27a82fec9d3b5abc3c8787cd38548556
Author: Jacek Konieczny <j.konieczny at eggsoft.pl>
Date:   Thu Dec 8 13:48:01 2016 +0100

    disable PJ_HASH_USE_OWN_TOLOWER, as Digium recommends
    
    http://lists.digium.com/pipermail/asterisk-dev/2016-December/076026.html
    https://issues.asterisk.org/jira/browse/ASTERISK-26490

 config_site.h  | 9 +++++++++
 pjproject.spec | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)
---
diff --git a/pjproject.spec b/pjproject.spec
index da9a5f1..88ee90f 100644
--- a/pjproject.spec
+++ b/pjproject.spec
@@ -20,7 +20,7 @@
 Summary:	PJSIP - free and open source multimedia communication library
 Name:		pjproject
 Version:	2.5.5
-Release:	2
+Release:	3
 License:	GPL v2+
 Group:		Libraries
 Source0:	http://www.pjsip.org/release/%{version}/%{name}-%{version}.tar.bz2
diff --git a/config_site.h b/config_site.h
index 32fca7e..874fb2d 100644
--- a/config_site.h
+++ b/config_site.h
@@ -44,3 +44,12 @@
 /* Defaults too low for WebRTC */
 #define PJ_ICE_MAX_CAND 32
 #define PJ_ICE_MAX_CHECKS (PJ_ICE_MAX_CAND * 2)
+
+/*
+ * Do not ever enable PJ_HASH_USE_OWN_TOLOWER because the algorithm is
+ * inconsistently used when calculating the hash value and doesn't
+ * convert the same characters as pj_tolower()/tolower().  Thus you
+ * can get different hash values if the string hashed has certain
+ * characters in it.  (ASCII '@', '[', '\\', ']', '^', and '_')
+ */
+#undef PJ_HASH_USE_OWN_TOLOWER
================================================================

---- gitweb:

http://git.pld-linux.org/gitweb.cgi/packages/pjproject.git/commitdiff/3ca848fd27a82fec9d3b5abc3c8787cd38548556



More information about the pld-cvs-commit mailing list