[packages/ImageMagick] use bash for running tests
atler
atler at pld-linux.org
Sun Jun 30 20:48:53 CEST 2024
commit 7c75582cf394f7173588c3f94dc1be95bd1bdfe4
Author: Jan Palus <atler at pld-linux.org>
Date: Sun Jun 30 18:02:41 2024 +0200
use bash for running tests
one of the tests requires shell which keeps file descriptors open on
execve:
exec 5<${SRCDIR}/rose.pnm
${MAGICK} fd:5 info: && echo "ok" || echo "not ok"
exec 5<&-
mksh is not one of those shells as it sets FD_CLOEXEC after opening file
descriptor:
https://github.com/MirBSD/mksh/blob/8b6f1b53521283f667b0b7644899feaddaf08d71/funcs.c#L2487
unfortunately POSIX leaves it up to implementation whether opened
descriptors should remain open in executed binaries ("it is unspecified
whether those file descriptors remain open when the shell invokes
another utility"):
https://pubs.opengroup.org/onlinepubs/000095399/utilities/exec.html
ImageMagick.spec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/ImageMagick.spec b/ImageMagick.spec
index 39b5995..de8f745 100644
--- a/ImageMagick.spec
+++ b/ImageMagick.spec
@@ -803,7 +803,7 @@ touch www/Magick++/NEWS.html www/Magick++/ChangeLog.html
%{__make} -j1
%{__sed} -i -e 's,/%{name}-%{ver}/,/%{name}-doc-%{version}/,' utilities/*.1
-%{?with_tests:%{__make} check}
+%{?with_tests:%{__make} LOG_COMPILER="%__bash" check}
%install
rm -rf $RPM_BUILD_ROOT
================================================================
---- gitweb:
http://git.pld-linux.org/gitweb.cgi/packages/ImageMagick.git/commitdiff/7c75582cf394f7173588c3f94dc1be95bd1bdfe4
More information about the pld-cvs-commit
mailing list