SOURCES: tdb-tdb_store.patch (NEW), tdb-Makefile-extras.patch (NEW...

Tomasz Mateja tommat at pimpek.one.pl
Sat Nov 13 11:58:49 CET 2004



On Sat, 13 Nov 2004, wrobell wrote:

>>>>>> + noinst_PROGRAMS=tdbspeed tdbiterate $(TDBTEST) $(TDBTORTURE)
>>>>>> +-bin_PROGRAMS=tdbtool tdbdump
>>>>>> ++bin_PROGRAMS=tdbtool tdbdump $(noinst_PROGRAMS)
>>>>>> +
>>>>>> + lib_LTLIBRARIES=libtdb.la
>>>>>> +
>>>>>
>>>>> This "fix" is incorrect. I you want install some programs then move it to
>>>>> bin_PROGRAMS but not add whole noinst_PROGRAMS to bin_PROGRAMS.
>>>>>
>>>> What's the differece between this fix and fix in which Ill copy paste
>>>> whole list ??
>>>
>>> Shorten Makefile.in, cleaner solution.
>>>
>> I dont understand, shorten is now. If you have your own better solution -
>> please fix it.
> Common... Don't you see that this line is a crap? Moreover it is harder to
> spot what programs are installed and maybe there will be programs, which
> really should not be installed (i.e. tests) in the future, so your solution
> is really error prone.
>
--- tdb-1.0.6/Makefile.am.orig  2001-12-11 05:05:13.000000000 +0100
+++ tdb-1.0.6/Makefile.am       2004-11-12 00:33:16.133127976 +0100
@@ -14,7 +14,7 @@
  endif

  noinst_PROGRAMS=tdbspeed tdbiterate $(TDBTEST) $(TDBTORTURE)
-bin_PROGRAMS=tdbtool tdbdump
+bin_PROGRAMS=tdbtool tdbdump tdbspeed tdbiterate $(TDBTEST) $(TDBTORTURE)

  lib_LTLIBRARIES=libtdb.la

I hope now is ok. Idont know why you guys prefer talking than do small 
fix.

-- 
tommat




More information about the pld-devel-en mailing list