SOURCES: pwdutils.login.defs - fix locale issue

Elan Ruusamäe glen at delfi.ee
Tue Nov 30 10:56:37 CET 2004


On Tuesday 30 November 2004 02:23, Radoslaw Zielinski wrote:
> In pld.cvs.commit you wrote:
> > Author: glen                         Date: Mon Nov 29 10:29:25 2004 GMT
> > Module: SOURCES                       Tag: HEAD
> > ---- Log message:
> > - fix locale issue
>
> [...]
>
> > +# Address this issue:
> > +# http://lists.suse.com/archive/pwdutils/2004-Nov/0003.html
> > +CHARACTER_CLASS               
> > [[:alpha:]_][[:alnum:]_.-]*[[:alnum:]_.$-]\?
>
> This is wrong.  As you were told on that mailing list, [:alpha:] is too
> wide.  Group names must not contain characters, which fit in this class.
> It is designed to be locale-dependent, while the constraint on how
> should a valid group name look like is not.
>
> In my opinion, [a-z] should always mean 26 characters, regardless of any
> locale settings; if it doesn't, it's a bug.  So, you're fixing the issue
> in the wrong place.
i agree.

how do you suggest to fix it, so the locale collation does not play role in 
regex?

force locale = C before regcomp() call?

write all letters out like Thorsten said in 
http://lists.suse.com/archive/pwdutils/2004-Nov/0008.html

?

-- 
glen




More information about the pld-devel-en mailing list