SOURCES: opensshd.init - use start-stop-daemon to stop *only* list...

Elan Ruusamäe glen at delfi.ee
Fri Aug 12 09:25:52 CEST 2005


On Friday 12 August 2005 10:05, Arkadiusz Miskiewicz wrote:
> On Thursday 11 of August 2005 22:43, glen wrote:
> > Author: glen                         Date: Thu Aug 11 20:43:47 2005 GMT
> > Module: SOURCES                       Tag: HEAD
> > ---- Log message:
> > - use start-stop-daemon to stop *only* listening sshd until somebody does
> > it with rc-scripts tools
> >
> >
> >  	if [ -f /var/lock/subsys/sshd ]; then
> >  		msg_stopping OpenSSH
> > -		killproc sshd
> > -		rm -f /var/run/sshd.pid /var/lock/subsys/sshd >/dev/null 2>&1
> > +		# we use start-stop-daemon to stop sshd, as it is unacceptable for
> > such +		# critical service as sshd to kill it by procname, but
> > unfortunately +		# rc-scripts does not provide way to kill *only* by
> > pidfile
> > +		start-stop-daemon --stop --quiet --pidfile /var/run/sshd.pid && ok ||
> > fail +		rm -f /var/lock/subsys/sshd >/dev/null 2>&1
>
> *PLEASE* fix / add new functionality to rc-scripts instead of messing with
> init script.
i don't feel comfortable at all when killproc kills processes by name, if 
--pidfile option was specified. but that's the current behaviour, if 
--pidfile is specifed, it will kill by that file contents, but if that file 
*doesn't exist*, it will go kill by procname, regardless that --pidfile was 
specified. i think that behaviour is to be changed to "--pidfile kills only 
by pidfile, never by procname"

> What will happen if every developer will write own things in 
> init scripts because he is too lazy to change rc-scripts?
world will be a better place and maintainer of rc-scripts will take good 
features from initscripts and add it to rc-scripts :)

> Add --pidfileonly option to killproc for example.


-- 
glen



More information about the pld-devel-en mailing list