SOURCES: go7007-hotplug.patch (NEW) - a patch for the hotplug scri...

[Patrys :: Patryk Zawadzki]

Dnia 30-08-2005, wto o godzinie 01:19 +0200, Jakub Piotr Cłapa
napisał(a):
> jpc wrote:
> > Index: SOURCES/go7007-hotplug.patch
> > diff -u /dev/null SOURCES/go7007-hotplug.patch:1.1
> > --- /dev/null	Mon Aug 29 14:13:55 2005
> > +++ SOURCES/go7007-hotplug.patch	Mon Aug 29 14:13:50 2005
> > @@ -0,0 +1,16 @@
> > +--- wis-go7007-linux-0.9.6/hotplug/wis-ezusb.in~	2005-08-04 04:04:01.000000000 +0200
> > ++++ wis-go7007-linux-0.9.6/hotplug/wis-ezusb.in	2005-08-28 20:02:17.147394816 +0200
> > +@@ -84,10 +84,11 @@
> > + fi
> > + 
> > + $LOADER $FLAGS -I $FIRMWARE
> > ++$RETVAL=$?
> > + 
> > +-if [ $? -gt 0 ]; then
> > ++if [ $RETVAL -gt 0 ]; then
> > +     if [ -x /usr/bin/logger ]; then
> > +-        /usr/bin/logger -t $0 "error $? returned by $LOADER $FLAGS -I $FIRMWARE"
> > ++        /usr/bin/logger -t $0 "error $RETVAL returned by $LOADER $FLAGS -I $FIRMWARE"
> > +     fi
> > +     exit 1
> > + fi
> 
> Is this change needed or just cosmetic? (I'm the one who wrote this but 
> I'm not really sure ;)

Here it looks like pure cosmetics (no execution prior to testing $?) but
it is more convenient to save it so if one adds one more instruction in
the conditional block it continues to work.

-- 
Patrys :: Patryk Zawadzki <patrys at pld-linux.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : /mailman/pipermail/pld-devel-en/attachments/20050830/d7680e68/attachment-0002.bin