SPECS: xplanet.spec - %{_includedir} macro used

Elan Ruusamäe glen at delfi.ee
Tue Dec 13 10:32:37 CET 2005


On Monday 12 December 2005 19:06, you wrote:
> Author: czucz                        Date: Mon Dec 12 17:06:18 2005 GMT
> Module: SPECS                         Tag: HEAD
> ---- Log message:
> - %{_includedir} macro used
what for?
it's not safe thing to do.
if somebody redefines _includedir in .spec, you change will break

ps: adapter is not always right!
[...]
> ================================================================
> Index: SPECS/xplanet.spec
> diff -u SPECS/xplanet.spec:1.19 SPECS/xplanet.spec:1.20
> --- SPECS/xplanet.spec:1.19	Sun Jul 17 04:01:08 2005
> +++ SPECS/xplanet.spec	Mon Dec 12 18:06:09 2005
[...]
>  %{__make} \
> -	CPPFLAGS="-I/usr/include/freetype2 -I/usr/X11R6/include -I`pwd`" \
> +	CPPFLAGS="-I%{_includedir}/freetype2 -I/usr/X11R6/include -I`pwd`" \
>  	CXXFLAGS="%{rpmcflags}"


-- 
glen



More information about the pld-devel-en mailing list