SPECS: xplanet.spec - %{_includedir} macro used

[Tomasz Wittner]

On Tue 13. of December 2005 10:53, Andrzej Krzysztofowicz wrote:
> Elan =?iso-8859-1?q?Ruusam=E4e?= wrote:
> > On Monday 12 December 2005 19:06, you wrote:
> > > Author: czucz                        Date: Mon Dec 12 17:06:18 2005 GMT
> > > Module: SPECS                         Tag: HEAD
> > > ---- Log message:
> > > - %{_includedir} macro used
> >
> > what for?
> > it's not safe thing to do.
> > if somebody redefines _includedir in .spec, you change will break
Yesterday, I expressed similar reservations on pld-devel-pl@ ...
> >
> > ps: adapter is not always right!
>
> Exactly. It is to be reverted.
>
> > [...]
> >
> > > -	CPPFLAGS="-I/usr/include/freetype2 -I/usr/X11R6/include -I`pwd`" \
> > > +	CPPFLAGS="-I%{_includedir}/freetype2 -I/usr/X11R6/include -I`pwd`" \
See http://cia.navi.cx/stats/author/czucz or his last commits on 
pld-cvs-commit at . He made more such changes (ca in 20 specs). He reverted his 
changes only in xplanet.spec. Does he understand what he doing? - I'm not 
sure.
-- 
Tomasz Wittner