SPECS: bash-completion.spec - no need to check for

Andrzej Krzysztofowicz ankry at green.mif.pg.gda.pl
Thu Jan 13 14:51:34 CET 2005


glen wrote:
> Index: SPECS/bash-completion.spec
> diff -u SPECS/bash-completion.spec:1.111 SPECS/bash-completion.spec:1.112
> --- SPECS/bash-completion.spec:1.111	Thu Jan 13 13:00:37 2005
> +++ SPECS/bash-completion.spec	Thu Jan 13 13:07:13 2005
> @@ -62,7 +62,7 @@
>  # check for correct version of bash
>  bash=${BASH_VERSION%.*}; bmajor=${bash%.*}; bminor=${bash#*.}
>  if [ "$bmajor" -eq 2 -a "$bminor" '>' 04 ] || [ "$bmajor" -gt 2 ]; then
> -	if [ "$PS1" ] && [ -f %{_sysconfdir}/bash_completion ]; then # interactive shell
> +	if [ "$PS1" ]; then # interactive shell
>  		# Source completion code
>  		. %{_sysconfdir}/bash_completion
>  	fi

One doubt: shouldn't the "$" be \-quoted here?
(To avoid substitution while parsing specfile.)

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry at mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Gdansk University of Technology




More information about the pld-devel-en mailing list